Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 29ec4b7416ba4b8bfdbba64ce6c6ed13d53a2b1e..ae81a78c4d089199c3c8ecbbf71e6cfa8d05d6cc 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -53,11 +53,11 @@
#include "content/common/host_shared_bitmap_manager.h"
#include "content/common/input_messages.h"
#include "content/common/view_messages.h"
+#include "content/public/browser/bad_message.h"
#include "content/public/browser/native_web_keyboard_event.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_widget_host_iterator.h"
-#include "content/public/browser/user_metrics.h"
#include "content/public/common/content_constants.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/result_codes.h"
@@ -1600,8 +1600,7 @@ void RenderWidgetHostImpl::OnQueueSyntheticGesture(
// Only allow untrustworthy gestures if explicitly enabled.
if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
cc::switches::kEnableGpuBenchmarking)) {
- RecordAction(base::UserMetricsAction("BadMessageTerminate_RWH7"));
- GetProcess()->ReceivedBadMessage();
+ GetProcess()->ReceivedBadMessage(BadMessage::RWH_SYNTHETIC_GESTURE);
return;
}
@@ -1613,14 +1612,12 @@ void RenderWidgetHostImpl::OnQueueSyntheticGesture(
void RenderWidgetHostImpl::OnFocus() {
// Only RenderViewHost can deal with that message.
- RecordAction(base::UserMetricsAction("BadMessageTerminate_RWH4"));
- GetProcess()->ReceivedBadMessage();
+ GetProcess()->ReceivedBadMessage(BadMessage::RWH_FOCUS);
}
void RenderWidgetHostImpl::OnBlur() {
// Only RenderViewHost can deal with that message.
- RecordAction(base::UserMetricsAction("BadMessageTerminate_RWH5"));
- GetProcess()->ReceivedBadMessage();
+ GetProcess()->ReceivedBadMessage(BadMessage::RWH_BLUR);
}
void RenderWidgetHostImpl::OnSetCursor(const WebCursor& cursor) {
@@ -1695,8 +1692,7 @@ void RenderWidgetHostImpl::OnShowDisambiguationPopup(
scoped_ptr<cc::SharedBitmap> bitmap =
HostSharedBitmapManager::current()->GetSharedBitmapFromId(size, id);
if (!bitmap) {
- RecordAction(base::UserMetricsAction("BadMessageTerminate_RWH6"));
- GetProcess()->ReceivedBadMessage();
+ GetProcess()->ReceivedBadMessage(BadMessage::RWH_SHARED_BITMAP);
return;
}
@@ -1891,8 +1887,7 @@ void RenderWidgetHostImpl::OnTouchEventAck(
void RenderWidgetHostImpl::OnUnexpectedEventAck(UnexpectedEventAckType type) {
if (type == BAD_ACK_MESSAGE) {
- RecordAction(base::UserMetricsAction("BadMessageTerminate_RWH2"));
- process_->ReceivedBadMessage();
+ process_->ReceivedBadMessage(BadMessage::RWH_BAD_ACK_MESSAGE);
} else if (type == UNEXPECTED_EVENT_TYPE) {
suppress_next_char_events_ = false;
}

Powered by Google App Engine
This is Rietveld 408576698