Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index c9083b4bd5ca92f00f85d4a185b4bb1c128bfdfc..5f541961004b64a4b87093f0f727e5f2a4f770d9 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -49,6 +49,7 @@
#include "content/common/swapped_out_messages.h"
#include "content/common/view_messages.h"
#include "content/public/browser/ax_event_notification_details.h"
+#include "content/public/browser/bad_message.h"
#include "content/public/browser/browser_accessibility_state.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_message_filter.h"
@@ -1002,7 +1003,8 @@ void RenderViewHostImpl::OnUpdateState(int32 page_id, const PageState& state) {
// Without this check, the renderer can trick the browser into using
// filenames it can't access in a future session restore.
if (!CanAccessFilesOfPageState(state)) {
- GetProcess()->ReceivedBadMessage();
+ GetProcess()->ReceivedBadMessage(
+ BadMessage::RVH_CAN_ACCESS_FILES_OF_PAGE_STATE);
return;
}
@@ -1368,7 +1370,7 @@ void RenderViewHostImpl::OnRunFileChooser(const FileChooserParams& params) {
// renderer to coerce the browser to perform I/O on a renderer controlled
// path.
if (params.default_file_name != params.default_file_name.BaseName()) {
- GetProcess()->ReceivedBadMessage();
+ GetProcess()->ReceivedBadMessage(BadMessage::RVH_FILE_CHOOSER_PATH);
return;
}

Powered by Google App Engine
This is Rietveld 408576698