Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: net/tools/quic/quic_time_wait_list_manager_test.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_spdy_server_stream_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_time_wait_list_manager_test.cc
diff --git a/net/tools/quic/quic_time_wait_list_manager_test.cc b/net/tools/quic/quic_time_wait_list_manager_test.cc
index f67fe7e2c4eda25ee12743b6ef60c4ada468df6e..724f60170872a21eb46bc0c276a6a9e2f25eac3f 100644
--- a/net/tools/quic/quic_time_wait_list_manager_test.cc
+++ b/net/tools/quic/quic_time_wait_list_manager_test.cc
@@ -90,9 +90,13 @@ class MockFakeTimeEpollServer : public FakeTimeEpollServer {
class QuicTimeWaitListManagerTest : public ::testing::Test {
protected:
QuicTimeWaitListManagerTest()
- : time_wait_list_manager_(&writer_, &visitor_,
- &epoll_server_, QuicSupportedVersions()),
- framer_(QuicSupportedVersions(), QuicTime::Zero(), true),
+ : time_wait_list_manager_(&writer_,
+ &visitor_,
+ &epoll_server_,
+ QuicSupportedVersions()),
+ framer_(QuicSupportedVersions(),
+ QuicTime::Zero(),
+ Perspective::IS_SERVER),
connection_id_(45),
client_address_(net::test::TestPeerIPAddress(), kTestPort),
writer_is_blocked_(false) {}
@@ -184,9 +188,8 @@ class ValidatePublicResetPacketPredicate
const std::tr1::tuple<const char*, int> packet_buffer,
testing::MatchResultListener* /* listener */) const override {
FramerVisitorCapturingPublicReset visitor;
- QuicFramer framer(QuicSupportedVersions(),
- QuicTime::Zero(),
- false);
+ QuicFramer framer(QuicSupportedVersions(), QuicTime::Zero(),
+ Perspective::IS_CLIENT);
framer.set_visitor(&visitor);
QuicEncryptedPacket encrypted(std::tr1::get<0>(packet_buffer),
std::tr1::get<1>(packet_buffer));
« no previous file with comments | « net/tools/quic/quic_spdy_server_stream_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698