Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Unified Diff: net/tools/quic/quic_client_session_test.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_client_session_test.cc
diff --git a/net/tools/quic/quic_client_session_test.cc b/net/tools/quic/quic_client_session_test.cc
index 47a708b0c7c5391be32f6bac3e19d026f234e414..c7d1f09c7a393f13ac116a5419ee25ad9a588d93 100644
--- a/net/tools/quic/quic_client_session_test.cc
+++ b/net/tools/quic/quic_client_session_test.cc
@@ -39,8 +39,8 @@ class ToolsQuicClientSessionTest
: public ::testing::TestWithParam<QuicVersion> {
protected:
ToolsQuicClientSessionTest()
- : connection_(
- new PacketSavingConnection(false, SupportedVersions(GetParam()))) {
+ : connection_(new PacketSavingConnection(Perspective::IS_CLIENT,
+ SupportedVersions(GetParam()))) {
session_.reset(new QuicClientSession(DefaultQuicConfig(), connection_));
session_->InitializeSession(
QuicServerId(kServerHostname, kPort, false, PRIVACY_MODE_DISABLED),
@@ -69,7 +69,7 @@ TEST_P(ToolsQuicClientSessionTest, CryptoConnect) {
TEST_P(ToolsQuicClientSessionTest, MaxNumStreams) {
session_->config()->SetMaxStreamsPerConnection(1, 1);
- // FLAGS_max_streams_per_connection = 1;
+
// Initialize crypto before the client session will create a stream.
CompleteCryptoHandshake();
« no previous file with comments | « net/tools/quic/quic_client.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698