Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: net/quic/congestion_control/tcp_cubic_sender_test.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.cc ('k') | net/quic/crypto/crypto_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/tcp_cubic_sender_test.cc
diff --git a/net/quic/congestion_control/tcp_cubic_sender_test.cc b/net/quic/congestion_control/tcp_cubic_sender_test.cc
index ab5fcdbc36b53660b760289d383ad6cb17d5aeba..1baffb0bcdbd0333f843795656c71325a626ffc8 100644
--- a/net/quic/congestion_control/tcp_cubic_sender_test.cc
+++ b/net/quic/congestion_control/tcp_cubic_sender_test.cc
@@ -501,8 +501,7 @@ TEST_F(TcpCubicSenderTest, ConfigureMaxInitialWindow) {
QuicTagVector options;
options.push_back(kIW10);
QuicConfigPeer::SetReceivedConnectionOptions(&config, options);
- sender_->SetFromConfig(config,
- /* is_server= */ true,
+ sender_->SetFromConfig(config, Perspective::IS_SERVER,
/* using_pacing= */ false);
EXPECT_EQ(10u, sender_->congestion_window());
}
@@ -511,8 +510,7 @@ TEST_F(TcpCubicSenderTest, DisableAckTrainDetectionWithPacing) {
EXPECT_TRUE(sender_->hybrid_slow_start().ack_train_detection());
QuicConfig config;
- sender_->SetFromConfig(config,
- /* is_server= */ true,
+ sender_->SetFromConfig(config, Perspective::IS_SERVER,
/* using_pacing= */ true);
EXPECT_FALSE(sender_->hybrid_slow_start().ack_train_detection());
}
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.cc ('k') | net/quic/crypto/crypto_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698