Issue 1009333003: Cherrypick post upload hook changes in PRESUBMIT.py of m41 branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1009333003: Cherrypick post upload hook changes in PRESUBMIT.py of m41 branch (Closed)

Created:
5 years, 9 months ago by rmistry

Modified:
5 years, 9 months ago

Reviewers:
borenet

CC:
reviews_skia.org, hcm

Base URL:
https://skia.googlesource.com/skia@m41

Target Ref:
refs/heads/chrome/m41

Project:
skia

Visibility:
Public.

Cherrypick post upload hook changes in PRESUBMIT.py of m41 branch CLs uploaded from this branch will now automatically contain 'NOTRY=true' and 'NOTREECHECKS=true'. These CLs are cherrypicked: https://codereview.chromium.org/960203002/ ('Automatically add a docs preview link and NOTRY=true when there are only docs changes') https://codereview.chromium.org/963553002/ ('Automatically add NOTREECHECKS when uploading CLs from non master branches') BUG=skia: NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/8e1f256f31ce14b2f3036cc7fc7664edaed31c5b

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View		3 chunks	+84 lines, -0 lines	0 comments	Download
	M	codereview.settings	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009333003/1

5 years, 9 months ago (2015-03-16 12:47:38 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-16 12:51:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8e1f256f31ce14b2f3036cc7fc7664edaed31c5b