Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 100923007: Revert 239400 "Revert 239280 "Move more file_util functions to b..." (Closed)

Created:
7 years ago by Nico
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 239400 "Revert 239280 "Move more file_util functions to b..." Broke all bots 9_9 > Revert 239280 "Move more file_util functions to base namespace." > > dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32). > This CL is the only in the intersection of CLs in the first failing build on > the two builders, so giving a speculative revert a try (rlarocque already > tried a clobber, it didn't help). > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806 > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544 > > > > Move more file_util functions to base namespace. > > > > TBR=sky > > > > Review URL: https://codereview.chromium.org/109043002 > > TBR=brettw@chromium.org > > Review URL: https://codereview.chromium.org/105823009 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -317 lines) Patch
M trunk/src/base/event_recorder_win.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/base/file_util.h View 2 chunks +7 lines, -12 lines 0 comments Download
M trunk/src/base/file_util.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M trunk/src/base/file_util_posix.cc View 2 chunks +21 lines, -32 lines 0 comments Download
M trunk/src/base/file_util_unittest.cc View 50 chunks +70 lines, -70 lines 0 comments Download
M trunk/src/base/file_util_win.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M trunk/src/base/files/file_util_proxy_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/base/memory/shared_memory_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/base/nix/mime_util_xdg.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/base/test/gtest_xml_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/base/test/launcher/test_results_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/base/test/perf_log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/base/win/shortcut_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/boot_times_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/login/startup_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/enterprise_install_attributes.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/settings/owner_key_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/component_updater/component_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/extension_creator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/external_registry_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/sandboxed_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/importer/firefox_profile_lock_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/net/net_log_temp_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/parsers/metadata_parser_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/safe_browsing/prefix_set.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/safe_browsing/prefix_set_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/storage_monitor/image_capture_device_manager_unittest.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/web_applications/web_app_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/tools/convert_dict/aff_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/tools/convert_dict/convert_dict.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/tools/convert_dict/dic_reader.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/components/visitedlink/browser/visitedlink_master.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/content/browser/browser_shutdown_profile_dumper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/fileapi/file_system_operation_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/tracing/tracing_controller_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/child/npapi/plugin_stream_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/common/gpu/client/gl_helper_benchmark.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/common/mac/font_loader.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/common/page_state_serialization_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/common/plugin_list_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/gpu/gpu_watchdog_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/media/media_stream_audio_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/plugin/plugin_geturl_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/weburl_loader_mock_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/gpu/tools/compositor_model_bench/compositor_model_bench.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/media/audio/android/audio_android_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/audio/audio_low_latency_input_output_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/audio/win/audio_low_latency_input_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/audio/win/audio_low_latency_output_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/audio/win/audio_unified_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/audio/win/audio_unified_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/base/container_names_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/base/test_data_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/base/yuv_convert_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/media/webm/chromeos/webm_encoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/android/keystore_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/net/base/file_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/base/net_log_logger_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/net/disk_cache/backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/disk_cache/cache_util_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/net/proxy/proxy_config_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/tools/dump_cache/cache_dumper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/skia/ext/vector_canvas_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/sql/connection_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/sql/test/test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/imagediff/image_diff.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ui/base/resource/data_pack.cc View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
7 years ago (2013-12-08 21:42:52 UTC) #1
Nico
7 years ago (2013-12-08 21:43:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r239401.

Powered by Google App Engine
This is Rietveld 408576698