Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 100923003: Refactor FourByteInterps. Add 64-bit Fast version. Add tests. (Closed)

Created:
7 years ago by mtklein
Modified:
7 years ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Refactor FourByteInterps. Add 64-bit Fast version. Add tests. Effect on benches (only _fast_ should be affected, and only on 64-bit): Desktop (64-bit) four_byte_interp_slow_255 NONRENDERING c 7.80 7.84 -0.04 -0.5% four_byte_interp_slow_256 NONRENDERING c 7.38 7.36 +0.02 +0.3% four_byte_interp_fast_256 NONRENDERING c 4.86 4.38 +0.48 +9.9% four_byte_interp_fast_255 NONRENDERING c 5.80 5.16 +0.64 +11.0% N5 (32-bit) four_byte_interp_slow_256 NONRENDERING c 22.22 22.66 -0.44 -2.0% four_byte_interp_fast_255 NONRENDERING c 22.22 22.22 +0.00 +0.0% four_byte_interp_fast_256 NONRENDERING c 18.81 18.81 +0.00 +0.0% four_byte_interp_slow_255 NONRENDERING c 22.42 22.42 +0.00 +0.0% BUG= Committed: http://code.google.com/p/skia/source/detail?r=12468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -21 lines) Patch
M gyp/tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkColorPriv.h View 1 chunk +69 lines, -21 lines 0 comments Download
A tests/ColorPrivTest.cpp View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
7 years ago (2013-12-03 16:34:53 UTC) #1
reed1
lgtm next step: remove non-fast callers?
7 years ago (2013-12-03 17:32:23 UTC) #2
mtklein
On 2013/12/03 17:32:23, reed1 wrote: > lgtm > > next step: remove non-fast callers? Yep. ...
7 years ago (2013-12-03 18:33:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/100923003/1
7 years ago (2013-12-03 18:34:15 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-03 18:53:32 UTC) #5
Message was sent while issue was closed.
Change committed as 12468

Powered by Google App Engine
This is Rietveld 408576698