Issue 100923002: Revert 225751 "BitmapContentLayerUpdater shouldn't reallocate bi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100923002: Revert 225751 "BitmapContentLayerUpdater shouldn't reallocate bi..." (Closed)

Created:
7 years ago by jbauman

Modified:
7 years ago

Reviewers:
jbauman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 225751 "BitmapContentLayerUpdater shouldn't reallocate bi..." > BitmapContentLayerUpdater shouldn't reallocate bitmap smaller. > > BitmapContentLayerUpdater was always allocating a new bitmap if the size of the region to be drawn changed, even if the new region was smaller. These unnecessary reallocations can be very expensive because they require page faults and for the operating system to clear out the memory. > > BUG=296423 > R=ben@chromium.org, enne@chromium.org, vangelis@chromium.org > > Review URL: https://codereview.chromium.org/24486002 BUG=296423, 321937 TBR=jbauman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238280

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -20 lines)			Patch
M	trunk/src/cc/resources/bitmap_content_layer_updater.cc	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	trunk/src/cc/resources/content_layer_updater.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/cc/resources/content_layer_updater.cc	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	trunk/src/cc/resources/skpicture_content_layer_updater.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/compositor/layer_unittest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r238280.