Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 24486002: BitmapContentLayerUpdater shouldn't reallocate bitmap smaller. (Closed)

Created:
7 years, 3 months ago by jbauman
Modified:
7 years, 2 months ago
CC:
chromium-reviews, ben+watch_chromium.org, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

BitmapContentLayerUpdater shouldn't reallocate bitmap smaller. BitmapContentLayerUpdater was always allocating a new bitmap if the size of the region to be drawn changed, even if the new region was smaller. These unnecessary reallocations can be very expensive because they require page faults and for the operating system to clear out the memory. BUG=296423 R=ben@chromium.org, enne@chromium.org, vangelis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225751

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M cc/resources/bitmap_content_layer_updater.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download
M cc/resources/content_layer_updater.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/content_layer_updater.cc View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
M cc/resources/skpicture_content_layer_updater.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_unittest.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbauman
7 years, 2 months ago (2013-09-26 02:50:16 UTC) #1
enne (OOO)
lgtm
7 years, 2 months ago (2013-09-26 18:35:03 UTC) #2
Vangelis Kokkevis
lgtm
7 years, 2 months ago (2013-09-26 18:49:49 UTC) #3
jbauman
Also adding ben@ to review the layer_unittest.cc change.
7 years, 2 months ago (2013-09-27 00:42:15 UTC) #4
Ben Goodger (Google)
lgtm
7 years, 2 months ago (2013-09-27 04:47:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/24486002/26001
7 years, 2 months ago (2013-09-27 05:11:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=82157
7 years, 2 months ago (2013-09-27 08:53:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/24486002/26001
7 years, 2 months ago (2013-09-27 10:51:19 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=82299
7 years, 2 months ago (2013-09-27 15:44:30 UTC) #9
jbauman
7 years, 2 months ago (2013-09-27 19:13:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 manually as r225751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698