Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 1009103003: MIPS32EL: Add clang compiler flags for MIPS32 - Android (Closed)

Created:
5 years, 9 months ago by gordanac
Modified:
5 years ago
Reviewers:
cjhopman, Nico, gordana.cmiljanovic
CC:
chromium-reviews, petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MIPS32EL: Add clang compiler flags for MIPS32 - Android This adds compiler flags to enable Chromium Android for mips32 to be compiled using clang. GCC remains the default compiler. BUG= TEST=Manually: export GYP_DEFINES="OS=android target_arch=mipsel clang=1" ./build/gyp_chromium ninja -C out/Release Committed: https://crrev.com/549e89dae53fba944de71ee0864d83520c6f5ecc Cr-Commit-Position: refs/heads/master@{#322564}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +44 lines, -4 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
gordanac
Please take a look.
5 years, 9 months ago (2015-03-18 13:08:01 UTC) #3
cjhopman
lgtm
5 years, 9 months ago (2015-03-26 21:25:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009103003/1
5 years, 9 months ago (2015-03-27 10:58:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 12:46:49 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/549e89dae53fba944de71ee0864d83520c6f5ecc Cr-Commit-Position: refs/heads/master@{#322564}
5 years, 9 months ago (2015-03-27 12:47:42 UTC) #8
Nico
https://codereview.chromium.org/1009103003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1009103003/diff/1/build/common.gypi#newcode4141 build/common.gypi:4141: '-no-integrated-as', Everything builds fine for me with OS=android target_arch=mipsel ...
5 years ago (2015-11-30 18:47:47 UTC) #10
Nico
On 2015/11/30 18:47:47, Nico wrote: > https://codereview.chromium.org/1009103003/diff/1/build/common.gypi > File build/common.gypi (right): > > https://codereview.chromium.org/1009103003/diff/1/build/common.gypi#newcode4141 > ...
5 years ago (2015-11-30 20:01:30 UTC) #11
gordanac
5 years ago (2015-12-04 18:36:11 UTC) #12
Message was sent while issue was closed.
On 2015/11/30 20:01:30, Nico wrote:
> On 2015/11/30 18:47:47, Nico wrote:
> > https://codereview.chromium.org/1009103003/diff/1/build/common.gypi
> > File build/common.gypi (right):
> > 
> >
>
https://codereview.chromium.org/1009103003/diff/1/build/common.gypi#newcode4141
> > build/common.gypi:4141: '-no-integrated-as',
> > Everything builds fine for me with OS=android target_arch=mipsel even if I
> > remove this flag. Did you need it locally, or is this here just because the
> arm
> > block had it?
> 
> Hm, actually some things are broken without this flag on mips. Nevermind.


There is some mips inline asm code which clang cannot handle well.
(you need flags: OS=android target_arch=mipsel clang=1)

Actually, clang sets 'no-integrates-as' by default for MIPS, but it was added
here
to stress the need for it.

Please take a look into https://codereview.chromium.org/1503523002
which fix the current issue.

Powered by Google App Engine
This is Rietveld 408576698