Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1503523002:
Put back path to Android MIPS gnu as for clang (Closed)
DescriptionPut back path to Android MIPS gnu as for clang
Since '-no-integrated-as' is still used for all
Chromium targets for MIPS, put back the path to gnu as
which was exidentaly removed in:
https://codereview.chromium.org/1484883002
TEST=export GYP_DEFINES="OS=android target_arch=mipsel clang=1"
build/gyp_chromium
ninja -C out/Release chrome_public_apk
BUG=ninja failed with error
"Fatal error: invalid -march= option: `mips32'
clang: error: assembler command failed with exit code 1"
Committed: https://crrev.com/aa9f445441a57681cdf114a6c3d4fea890926dce
Cr-Commit-Position: refs/heads/master@{#363456}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comment #
Total comments: 2
Patch Set 3 : #Messages
Total messages: 19 (9 generated)
gordana.cmiljanovic@imgtec.com changed reviewers: + thakis@chromium.org
Please take a look.
Whoops, sorry. https://codereview.chromium.org/1503523002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1503523002/diff/1/build/common.gypi#newcode4236 build/common.gypi:4236: '-B<(android_toolchain)', # Else /usr/bin/as gets picked up. Can you put this next to the -no-integrated-as line like so: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/ffmpeg... ?
Modified. https://codereview.chromium.org/1503523002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1503523002/diff/1/build/common.gypi#newcode4236 build/common.gypi:4236: '-B<(android_toolchain)', # Else /usr/bin/as gets picked up. On 2015/12/04 18:50:31, Nico wrote: > Can you put this next to the -no-integrated-as line like so: > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/ffmpeg... > ? Done.
lgtm, thanks! https://codereview.chromium.org/1503523002/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1503523002/diff/20001/build/common.gypi#newco... build/common.gypi:4230: 'cflags': [ '-no-integrated-as' ], nit: Since you're touching this line anyways, maybe you could change the spelling to -fno-integrated-as (does the same thing but is nicer since this is really a feature flag and those usually start with -f)
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
The CQ bit was unchecked by gordana.cmiljanovic@imgtec.com
gordana.cmiljanovic@imgtec.com changed reviewers: + gordana.cmiljanovic@imgtec.com - Gordana.Cmiljanovic@imgtec.com
https://codereview.chromium.org/1503523002/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1503523002/diff/20001/build/common.gypi#newco... build/common.gypi:4230: 'cflags': [ '-no-integrated-as' ], On 2015/12/04 19:30:19, Nico wrote: > nit: Since you're touching this line anyways, maybe you could change the > spelling to -fno-integrated-as (does the same thing but is nicer since this is > really a feature flag and those usually start with -f) Done.
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1503523002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503523002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503523002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Put back path to Android MIPS gnu as for clang Since '-no-integrated-as' is still used for all Chromium targets for MIPS, put back the path to gnu as which was exidentaly removed in: https://codereview.chromium.org/1484883002 TEST=export GYP_DEFINES="OS=android target_arch=mipsel clang=1" build/gyp_chromium ninja -C out/Release chrome_public_apk BUG=ninja failed with error "Fatal error: invalid -march= option: `mips32' clang: error: assembler command failed with exit code 1" ========== to ========== Put back path to Android MIPS gnu as for clang Since '-no-integrated-as' is still used for all Chromium targets for MIPS, put back the path to gnu as which was exidentaly removed in: https://codereview.chromium.org/1484883002 TEST=export GYP_DEFINES="OS=android target_arch=mipsel clang=1" build/gyp_chromium ninja -C out/Release chrome_public_apk BUG=ninja failed with error "Fatal error: invalid -march= option: `mips32' clang: error: assembler command failed with exit code 1" Committed: https://crrev.com/aa9f445441a57681cdf114a6c3d4fea890926dce Cr-Commit-Position: refs/heads/master@{#363456} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/aa9f445441a57681cdf114a6c3d4fea890926dce Cr-Commit-Position: refs/heads/master@{#363456} |
