extensions/browser/guest_view/guest_view_base.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/extension_options/extension_options_guest.cc ('k') | extensions/browser/guest_view/guest_view_base.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_base.h

diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h

index 231275f9cc1a7b499edb2cdb5494611222914e7a..b8e45eff217af4f3ce4a201bc74988d360035da8 100644

--- a/extensions/browser/guest_view/guest_view_base.h

+++ b/extensions/browser/guest_view/guest_view_base.h

@@ -103,7 +103,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

// This method is called when the initial set of frames within the page have

// completed loading.

- virtual void DidStopLoading() {}

+ virtual void GuestViewDidStopLoading() {}

// This method is called before the embedder is destroyed.

// |owner_web_contents_| should still be valid during this call. This

@@ -317,7 +317,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

double PhysicalPixelsToLogicalPixels(int physical_pixels);

// WebContentsObserver implementation.

- void DidStopLoading(content::RenderViewHost* render_view_host) final;

+ void DidStopLoading() final;

void RenderViewReady() final;

void WebContentsDestroyed() final;