extensions/browser/guest_view/extension_options/extension_options_guest.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/extension_host.cc ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.h

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h

index 141906d8900d935b2ff5ae7fc6b885bab86b4531..f3b9becd958c5f8663ca67e07719033a9fc6fdf3 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h

@@ -30,7 +30,7 @@ class ExtensionOptionsGuest

void CreateWebContents(const base::DictionaryValue& create_params,

const WebContentsCreatedCallback& callback) override;

void DidInitialize(const base::DictionaryValue& create_params) override;

- void DidStopLoading() override;

+ void GuestViewDidStopLoading() override;

const char* GetAPINamespace() const override;

int GetTaskPrefix() const override;

bool IsPreferredSizeModeEnabled() const override;