content/public/browser/web_contents_observer.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_observer.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/public/test/browser_test_utils.h » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents_observer.h

diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h

index 0cc85e0a47842f2e18d189c055f2efc519718e10..a176d18cbb06363238243250980f44e7083962b3 100644

--- a/content/public/browser/web_contents_observer.h

+++ b/content/public/browser/web_contents_observer.h

@@ -244,8 +244,8 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,

// These two methods correspond to the points in time when the spinner of the

// tab starts and stops spinning.

- virtual void DidStartLoading(RenderViewHost* render_view_host) {}

- virtual void DidStopLoading(RenderViewHost* render_view_host) {}

+ virtual void DidStartLoading() {}

+ virtual void DidStopLoading() {}

// When WebContents::Stop() is called, the WebContents stops loading and then

// invokes this method. If there are ongoing navigations, their respective