content/browser/android/web_contents_observer_proxy.cc - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_proxy.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/web_contents_observer_proxy.h ('k') | content/browser/frame_host/interstitial_page_impl.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/web_contents_observer_proxy.cc

diff --git a/content/browser/android/web_contents_observer_proxy.cc b/content/browser/android/web_contents_observer_proxy.cc

index 8566beee8315a1a60cafb699b863384b2206b076..a8e5eacfbdafc57be8f5b0e04358310cda91b4a6 100644

--- a/content/browser/android/web_contents_observer_proxy.cc

+++ b/content/browser/android/web_contents_observer_proxy.cc

@@ -79,8 +79,7 @@ void WebContentsObserverProxy::RenderProcessGone(

was_oom_protected);

}

-void WebContentsObserverProxy::DidStartLoading(

- RenderViewHost* render_view_host) {

+void WebContentsObserverProxy::DidStartLoading() {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj(weak_java_observer_.get(env));

if (obj.is_null())

@@ -91,8 +90,7 @@ void WebContentsObserverProxy::DidStartLoading(

jstring_url.obj());

}

-void WebContentsObserverProxy::DidStopLoading(

- RenderViewHost* render_view_host) {

+void WebContentsObserverProxy::DidStopLoading() {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj(weak_java_observer_.get(env));

if (obj.is_null())