chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h ('k') | content/browser/android/web_contents_observer_proxy.h » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

diff --git a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

index d4d88512a4bc5bffe2aca31570fb9bb1f505025c..5ccf6dbb0981e91967cac5778fe5ef506109c73e 100644

--- a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

+++ b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

@@ -49,15 +49,13 @@ PasswordManagerInternalsUI::~PasswordManagerInternalsUI() {

UnregisterFromLoggingServiceIfNecessary();

}

-void PasswordManagerInternalsUI::DidStartLoading(

- content::RenderViewHost* /* render_view_host */) {

+void PasswordManagerInternalsUI::DidStartLoading() {

// In case this tab is being reloaded, unregister itself until the reload is

// completed.

UnregisterFromLoggingServiceIfNecessary();

}

-void PasswordManagerInternalsUI::DidStopLoading(

- content::RenderViewHost* /* render_view_host */) {

+void PasswordManagerInternalsUI::DidStopLoading() {

DCHECK(!registered_with_logging_service_);

PasswordManagerInternalsService* service =

PasswordManagerInternalsServiceFactory::GetForBrowserContext(