chrome/browser/thumbnails/thumbnail_tab_helper.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/thumbnail_tab_helper.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/navigation_metrics_recorder.cc ('k') | chrome/browser/thumbnails/thumbnail_tab_helper.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/thumbnails/thumbnail_tab_helper.h

diff --git a/chrome/browser/thumbnails/thumbnail_tab_helper.h b/chrome/browser/thumbnails/thumbnail_tab_helper.h

index 560e443759d966bbb90d8b4f921c9bb27836c5b3..8e97064540bcdf5078b771432a25872e80fc713e 100644

--- a/chrome/browser/thumbnails/thumbnail_tab_helper.h

+++ b/chrome/browser/thumbnails/thumbnail_tab_helper.h

@@ -41,7 +41,7 @@ class ThumbnailTabHelper

// content::WebContentsObserver overrides.

void RenderViewDeleted(content::RenderViewHost* render_view_host) override;

- void DidStartLoading(content::RenderViewHost* render_view_host) override;

+ void DidStartLoading() override;

void NavigationStopped() override;

// Update the thumbnail of the given tab contents if necessary.