chrome/browser/printing/print_view_manager_base.cc - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager_base.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_view_manager_base.h ('k') | chrome/browser/safe_browsing/client_side_detection_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_view_manager_base.cc

diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/browser/printing/print_view_manager_base.cc

index efa7b1a4be1f9b3d129cc812c1053a3f173d1d25..a13e643a67cec6ad83b1041ea6f4d79305c332e7 100644

--- a/chrome/browser/printing/print_view_manager_base.cc

+++ b/chrome/browser/printing/print_view_manager_base.cc

@@ -202,8 +202,7 @@ void PrintViewManagerBase::OnShowInvalidPrinterSettingsError() {

chrome::MESSAGE_BOX_TYPE_WARNING);

}

-void PrintViewManagerBase::DidStartLoading(

- content::RenderViewHost* render_view_host) {

+void PrintViewManagerBase::DidStartLoading() {

UpdateScriptedPrintingBlocked();

}

« no previous file with comments | « chrome/browser/printing/print_view_manager_base.h ('k') | chrome/browser/safe_browsing/client_side_detection_host.h » ('j') | no next file with comments »