Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2239)

Unified Diff: cc/output/renderer_pixeltest.cc

Issue 1008493002: Increase YUV video clamping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/shader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/renderer_pixeltest.cc
diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc
index d02df4fb9f0cd8f0f7e24e7965ce0b8ba3dc9919..19bc68228b7f73302c3229d0e5652ce22b25c8c3 100644
--- a/cc/output/renderer_pixeltest.cc
+++ b/cc/output/renderer_pixeltest.cc
@@ -247,10 +247,23 @@ void CreateTestYUVVideoDrawQuad_FromVideoFrame(
resources.release_callbacks[media::VideoFrame::kAPlane]));
}
+ const gfx::Size ya_tex_size = video_frame->coded_size();
+ const gfx::Size uv_tex_size = media::VideoFrame::PlaneSize(
+ video_frame->format(), media::VideoFrame::kUPlane,
+ video_frame->coded_size());
+ DCHECK(uv_tex_size == media::VideoFrame::PlaneSize(
+ video_frame->format(), media::VideoFrame::kVPlane,
+ video_frame->coded_size()));
+ if (with_alpha) {
+ DCHECK(ya_tex_size == media::VideoFrame::PlaneSize(
+ video_frame->format(), media::VideoFrame::kAPlane,
+ video_frame->coded_size()));
+ }
+
YUVVideoDrawQuad* yuv_quad =
render_pass->CreateAndAppendDrawQuad<YUVVideoDrawQuad>();
yuv_quad->SetNew(shared_state, rect, opaque_rect, visible_rect,
- tex_coord_rect, video_frame->coded_size(), y_resource,
+ tex_coord_rect, ya_tex_size, uv_tex_size, y_resource,
u_resource, v_resource, a_resource, color_space);
}
@@ -939,7 +952,7 @@ class VideoGLRendererPixelTest : public GLRendererPixelTest {
// if the tex coords are not clamped.
CreateTestYUVVideoDrawQuad_TwoColor(
shared_state, format, false, tex_coord_rect, background_size,
- gfx::Rect(background_size), 0, 0, 0, green_rect, 149, 43, 21,
+ gfx::Rect(background_size), 128, 128, 128, green_rect, 149, 43, 21,
pass.get(), video_resource_updater_.get(), resource_provider_.get());
pass_list->push_back(pass.Pass());
}
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/shader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698