Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1008263003: [Smart Lock] Add a generic error message for out-of-date software. (Closed)

Created:
5 years, 9 months ago by Ilya Sherman
Modified:
5 years, 9 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Add a generic error message for out-of-date software. This message is shown when the remote device's name cannot be determined. BUG=453998 TEST=none R=tengs@chromium.org Committed: https://crrev.com/b25403d9df89f3c24f0a8e824686597454269969 Cr-Commit-Position: refs/heads/master@{#321321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ilya Sherman
5 years, 9 months ago (2015-03-18 22:59:13 UTC) #1
Tim Song
lgtm
5 years, 9 months ago (2015-03-19 06:15:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008263003/1
5 years, 9 months ago (2015-03-19 07:53:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 09:36:05 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 09:36:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b25403d9df89f3c24f0a8e824686597454269969
Cr-Commit-Position: refs/heads/master@{#321321}

Powered by Google App Engine
This is Rietveld 408576698