| Index: Source/core/frame/ImageBitmapTest.cpp
|
| diff --git a/Source/core/frame/ImageBitmapTest.cpp b/Source/core/frame/ImageBitmapTest.cpp
|
| index 09bb36251e6f901f1c2f38601ed49bca533e86c0..27648fb49d1d4e24aa9ba267ccbc72842b205363 100644
|
| --- a/Source/core/frame/ImageBitmapTest.cpp
|
| +++ b/Source/core/frame/ImageBitmapTest.cpp
|
| @@ -44,7 +44,6 @@
|
| #include "core/html/canvas/CanvasRenderingContext2D.h"
|
| #include "core/html/canvas/WebGLRenderingContext.h"
|
| #include "platform/graphics/BitmapImage.h"
|
| -#include "platform/graphics/skia/NativeImageSkia.h"
|
| #include "platform/heap/Handle.h"
|
| #include "platform/network/ResourceRequest.h"
|
| #include "wtf/OwnPtr.h"
|
| @@ -85,7 +84,7 @@ protected:
|
| TEST_F(ImageBitmapTest, ImageResourceConsistency)
|
| {
|
| RefPtrWillBeRawPtr<HTMLImageElement> imageElement = HTMLImageElement::create(*Document::create().get());
|
| - imageElement->setImageResource(new ImageResource(BitmapImage::create(NativeImageSkia::create(m_bitmap)).get()));
|
| + imageElement->setImageResource(new ImageResource(BitmapImage::create(m_bitmap).get()));
|
|
|
| RefPtrWillBeRawPtr<ImageBitmap> imageBitmapNoCrop = ImageBitmap::create(imageElement.get(), IntRect(0, 0, m_bitmap.width(), m_bitmap.height()));
|
| RefPtrWillBeRawPtr<ImageBitmap> imageBitmapInteriorCrop = ImageBitmap::create(imageElement.get(), IntRect(m_bitmap.width() / 2, m_bitmap.height() / 2, m_bitmap.width() / 2, m_bitmap.height() / 2));
|
| @@ -105,19 +104,19 @@ TEST_F(ImageBitmapTest, ImageResourceConsistency)
|
| TEST_F(ImageBitmapTest, ImageBitmapLiveResourcePriority)
|
| {
|
| RefPtrWillBePersistent<HTMLImageElement> imageNoCrop = HTMLImageElement::create(*Document::create().get());
|
| - ResourcePtr<ImageResource> cachedImageNoCrop = new ImageResource(ResourceRequest("http://foo.com/1"), BitmapImage::create(NativeImageSkia::create(m_bitmap)).get());
|
| + ResourcePtr<ImageResource> cachedImageNoCrop = new ImageResource(ResourceRequest("http://foo.com/1"), BitmapImage::create(m_bitmap).get());
|
| imageNoCrop->setImageResource(cachedImageNoCrop.get());
|
|
|
| RefPtrWillBePersistent<HTMLImageElement> imageInteriorCrop = HTMLImageElement::create(*Document::create().get());
|
| - ResourcePtr<ImageResource> cachedImageInteriorCrop = new ImageResource(ResourceRequest("http://foo.com/2"), BitmapImage::create(NativeImageSkia::create(m_bitmap)).get());
|
| + ResourcePtr<ImageResource> cachedImageInteriorCrop = new ImageResource(ResourceRequest("http://foo.com/2"), BitmapImage::create(m_bitmap).get());
|
| imageInteriorCrop->setImageResource(cachedImageInteriorCrop.get());
|
|
|
| RefPtrWillBePersistent<HTMLImageElement> imageExteriorCrop = HTMLImageElement::create(*Document::create().get());
|
| - ResourcePtr<ImageResource> cachedImageExteriorCrop = new ImageResource(ResourceRequest("http://foo.com/3"), BitmapImage::create(NativeImageSkia::create(m_bitmap)).get());
|
| + ResourcePtr<ImageResource> cachedImageExteriorCrop = new ImageResource(ResourceRequest("http://foo.com/3"), BitmapImage::create(m_bitmap).get());
|
| imageExteriorCrop->setImageResource(cachedImageExteriorCrop.get());
|
|
|
| RefPtrWillBePersistent<HTMLImageElement> imageOutsideCrop = HTMLImageElement::create(*Document::create().get());
|
| - ResourcePtr<ImageResource> cachedImageOutsideCrop = new ImageResource(ResourceRequest("http://foo.com/4"), BitmapImage::create(NativeImageSkia::create(m_bitmap)).get());
|
| + ResourcePtr<ImageResource> cachedImageOutsideCrop = new ImageResource(ResourceRequest("http://foo.com/4"), BitmapImage::create(m_bitmap).get());
|
| imageOutsideCrop->setImageResource(cachedImageOutsideCrop.get());
|
|
|
| MockImageResourceClient mockClient1, mockClient2, mockClient3, mockClient4;
|
| @@ -178,23 +177,26 @@ TEST_F(ImageBitmapTest, ImageBitmapLiveResourcePriority)
|
| TEST_F(ImageBitmapTest, ImageBitmapSourceChanged)
|
| {
|
| RefPtrWillBeRawPtr<HTMLImageElement> image = HTMLImageElement::create(*Document::create().get());
|
| - ResourcePtr<ImageResource> originalImageResource = new ImageResource(BitmapImage::create(NativeImageSkia::create(m_bitmap)).get());
|
| + ResourcePtr<ImageResource> originalImageResource = new ImageResource(BitmapImage::create(m_bitmap).get());
|
| image->setImageResource(originalImageResource.get());
|
|
|
| RefPtrWillBeRawPtr<ImageBitmap> imageBitmap = ImageBitmap::create(image.get(), IntRect(0, 0, m_bitmap.width(), m_bitmap.height()));
|
| ASSERT_EQ(imageBitmap->bitmapImage().get(), originalImageResource->image());
|
|
|
| - ResourcePtr<ImageResource> newImageResource = new ImageResource(BitmapImage::create(NativeImageSkia::create(m_bitmap2)).get());
|
| + ResourcePtr<ImageResource> newImageResource = new ImageResource(BitmapImage::create(m_bitmap2).get());
|
| image->setImageResource(newImageResource.get());
|
|
|
| // The ImageBitmap should contain the same data as the original cached image but should no longer hold a reference.
|
| ASSERT_NE(imageBitmap->bitmapImage().get(), originalImageResource->image());
|
| - ASSERT_EQ(imageBitmap->bitmapImage()->nativeImageForCurrentFrame()->bitmap().pixelRef()->pixels(),
|
| - originalImageResource->image()->nativeImageForCurrentFrame()->bitmap().pixelRef()->pixels());
|
| + SkBitmap bitmap1, bitmap2;
|
| + ASSERT_TRUE(imageBitmap->bitmapImage()->bitmapForCurrentFrame(&bitmap1));
|
| + ASSERT_TRUE(originalImageResource->image()->bitmapForCurrentFrame(&bitmap2));
|
| + ASSERT_EQ(bitmap1.pixelRef()->pixels(), bitmap2.pixelRef()->pixels());
|
|
|
| ASSERT_NE(imageBitmap->bitmapImage().get(), newImageResource->image());
|
| - ASSERT_NE(imageBitmap->bitmapImage()->nativeImageForCurrentFrame()->bitmap().pixelRef()->pixels(),
|
| - newImageResource->image()->nativeImageForCurrentFrame()->bitmap().pixelRef()->pixels());
|
| + ASSERT_TRUE(imageBitmap->bitmapImage()->bitmapForCurrentFrame(&bitmap1));
|
| + ASSERT_TRUE(newImageResource->image()->bitmapForCurrentFrame(&bitmap2));
|
| + ASSERT_NE(bitmap1.pixelRef()->pixels(), bitmap2.pixelRef()->pixels());
|
| }
|
|
|
| // Verifies that ImageBitmaps constructed from ImageBitmaps hold onto their own Image.
|
|
|