Source/core/frame/ImageBitmap.cpp - Issue 1008243003: Nuke NativeImageSkia -- new version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/ImageBitmap.cpp

Issue 1008243003: Nuke NativeImageSkia -- new version. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Convert BitmapImage::createFrameAtIndex() to Skia-style Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/ImageBitmap.cpp

diff --git a/Source/core/frame/ImageBitmap.cpp b/Source/core/frame/ImageBitmap.cpp

index 14c58ad575d0b86a9c9a2dda48082d9a8523002b..f5e1857d55d9d3e530de9ab3f27339705a911cb2 100644

--- a/Source/core/frame/ImageBitmap.cpp

+++ b/Source/core/frame/ImageBitmap.cpp

@@ -31,9 +31,10 @@ static inline PassRefPtr<Image> cropImage(Image* image, const IntRect& cropRect)

if (!intersectRect.width() || !intersectRect.height())

return nullptr;

- SkBitmap cropped;

- image->nativeImageForCurrentFrame()->bitmap().extractSubset(&cropped, intersectRect);

- return BitmapImage::create(NativeImageSkia::create(cropped));

+ SkBitmap bitmap, cropped;

+ image->bitmapForCurrentFrame(&bitmap);

+ bitmap.extractSubset(&cropped, intersectRect);

+ return BitmapImage::create(cropped);

}

ImageBitmap::ImageBitmap(HTMLImageElement* image, const IntRect& cropRect)