sync/internal_api/public/base/ordinal.h - Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base/ordinal.h

Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: '' Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/base/ordinal.h

diff --git a/sync/internal_api/public/base/ordinal.h b/sync/internal_api/public/base/ordinal.h

index c347b7b90be22016563f17dc7e1caf227bd6db02..cb67b4518b10b48b83046a2b95b278bd9bc8c368 100644

--- a/sync/internal_api/public/base/ordinal.h

+++ b/sync/internal_api/public/base/ordinal.h

@@ -260,8 +260,8 @@ bool Ordinal<Traits>::EqualsOrBothInvalid(const Ordinal& other) const {

template <typename Traits>

std::string Ordinal<Traits>::ToDebugString() const {

- std::string debug_string;

- base::JsonDoubleQuote(bytes_, false /* put_in_quotes */, &debug_string);

+ std::string debug_string =

+ base::EscapeBytesAsInvalidJSONString(bytes_, false /* put_in_quotes */);

if (!is_valid_) {

debug_string = "INVALID[" + debug_string + "]";

}