Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

sync/syncable/entry.cc

Index: sync/syncable/entry.cc
diff --git a/sync/syncable/entry.cc b/sync/syncable/entry.cc
index 3891c55402444383091bf5e4c0946e0c725ee584..852c33e32edee914422dfbf8c4d1d6c5e138df13 100644
--- a/sync/syncable/entry.cc
+++ b/sync/syncable/entry.cc
@@ -147,11 +147,9 @@ std::ostream& operator<<(std::ostream& os, const Entry& entry) {
     os << g_metas_columns[i].name << ": " << field << ", ";
   }
   for ( ; i < PROTO_FIELDS_END; ++i) {
-    std::string escaped_str;
-    base::JsonDoubleQuote(
+    std::string escaped_str = base::EscapeBytesAsInvalidJSONString(

[Mark Mentovai, 2013/12/06 15:35:12]

How careful were you in determining which of these were OK to use
EscapeJSONString and which had to use the garbage EscapeBytesAsInvalidJSONString
function?

[Robert Sesek, 2013/12/09 19:52:09]

Very. I just double-checked each one and reverted progress_marker_map.cc.
Everything else is debug-printing-only. I'll ask a sync/ OWNER to triple-check,
though.

         kernel->ref(static_cast<ProtoField>(i)).SerializeAsString(),
-        false,
-        &escaped_str);
+        false);
     os << g_metas_columns[i].name << ": " << escaped_str << ", ";
   }
   for ( ; i < UNIQUE_POSITION_FIELDS_END; ++i) {