chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc - Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: '' Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

index 58982a27cbe6927f6d504528674a25f0f18006a7..27f4c6016ec5a1db9120d45977753829bf40a1a7 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

@@ -35,7 +35,7 @@ class NativeMessagingHostManifestTest : public ::testing::Test {

const std::string& path,

const std::string& origin) {

std::string escaped_path;

- base::JsonDoubleQuote(path, false, &escaped_path);

+ base::EscapeJSONString(path, false, &escaped_path);

Mark Mentovai 2013/12/06 15:35:12 Why don’t you use the simpler non-out-param-having

Robert Sesek 2013/12/09 19:52:09 Done.

return WriteManifest("{"

" \"name\": \"" + name + "\","

" \"description\": \"Native Messaging Test\","

« base/json/string_escape.cc ('K') | « base/third_party/icu/icu_utf.h ('k') | chrome/browser/search/iframe_source.cc » ('j') | chrome/browser/search/iframe_source.cc » ('J')