Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/messaging/native_messaging_host_manifest.h"
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/string_escape.h"
@@ skipping 17 matching lines @@
   virtual void SetUp() OVERRIDE {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
     manifest_path_ = temp_dir_.path().AppendASCII("test.json");
   }
 
  protected:
   bool WriteManifest(const std::string& name,
                      const std::string& path,
                      const std::string& origin) {
     std::string escaped_path;
-    base::JsonDoubleQuote(path, false, &escaped_path);
+    base::EscapeJSONString(path, false, &escaped_path);

[Mark Mentovai, 2013/12/06 15:35:12]

Why don’t you use the simpler non-out-param-having returns-its-return-value
version of this function, and let it put the quotes on the string for you
(removing the quotes from the string constant)?

I will ask this question several more times.

[Robert Sesek, 2013/12/09 19:52:09]

Done.

     return WriteManifest("{"
       "  \"name\": \"" + name + "\","
       "  \"description\": \"Native Messaging Test\","
       "  \"path\": \"" + escaped_path + "\","
       "  \"type\": \"stdio\","
       "  \"allowed_origins\": ["
       "    \"" + origin + "\""
       "  ]"
       "}");
   }
@@ skipping 59 matching lines @@
                             "chrome-extension://*/"));
 
   std::string error_message;
   scoped_ptr<NativeMessagingHostManifest> manifest =
       NativeMessagingHostManifest::Load(manifest_path_, &error_message);
   ASSERT_FALSE(manifest);
   EXPECT_FALSE(error_message.empty());
 }
 
 }  // namespace extensions