Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: Source/platform/graphics/DrawLooperBuilder.cpp

Issue 1008173003: Move SkPaint mangement for 2D canvas into CanvasRenderingContext2DState (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixup2 Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/DrawLooperBuilder.cpp
diff --git a/Source/platform/graphics/DrawLooperBuilder.cpp b/Source/platform/graphics/DrawLooperBuilder.cpp
index 3b0a8f45ae0f94efb0a724f92aa75483c59f84f7..9788a756d47461fd9ab2665166574fe0f9778f63 100644
--- a/Source/platform/graphics/DrawLooperBuilder.cpp
+++ b/Source/platform/graphics/DrawLooperBuilder.cpp
@@ -63,13 +63,6 @@ void DrawLooperBuilder::addUnmodifiedContent()
m_skDrawLooperBuilder.addLayerOnTop(info);
}
-// This replicates the old skia behavior when it used to take radius for blur. Now it takes sigma.
-static SkScalar RadiusToSigma(SkScalar radius)
-{
- SkASSERT(radius > 0);
- return 0.57735f * radius + 0.5f;
-}
-
void DrawLooperBuilder::addShadow(const FloatSize& offset, float blur, const Color& color,
ShadowTransformMode shadowTransformMode, ShadowAlphaMode shadowAlphaMode)
{
@@ -101,7 +94,7 @@ void DrawLooperBuilder::addShadow(const FloatSize& offset, float blur, const Col
SkPaint* paint = m_skDrawLooperBuilder.addLayerOnTop(info);
if (blur) {
- const SkScalar sigma = RadiusToSigma(blur / 2);
+ const SkScalar sigma = skBlurRadiusToSigma(blur);
uint32_t mfFlags = SkBlurMaskFilter::kHighQuality_BlurFlag;
if (shadowTransformMode == ShadowIgnoresTransforms)
mfFlags |= SkBlurMaskFilter::kIgnoreTransform_BlurFlag;

Powered by Google App Engine
This is Rietveld 408576698