Oilpan: move WebDevToolsFrontend to the heap.

Source/web/WebDevToolsFrontendImpl.cpp

Index: Source/web/WebDevToolsFrontendImpl.cpp
diff --git a/Source/web/WebDevToolsFrontendImpl.cpp b/Source/web/WebDevToolsFrontendImpl.cpp
index 7cc3dec68ad527d9f89e144f1907a4423778c4ed..659c5bcb00dec7ae08cc674b8e591e0c045af00c 100644
--- a/Source/web/WebDevToolsFrontendImpl.cpp
+++ b/Source/web/WebDevToolsFrontendImpl.cpp
@@ -43,25 +43,7 @@
 
 namespace blink {
 
-WebDevToolsFrontend* WebDevToolsFrontend::create(
-    WebView* view,
-    WebDevToolsFrontendClient* client,
-    const WebString& applicationLocale)
-{
-    return new WebDevToolsFrontendImpl(toWebLocalFrameImpl(view->mainFrame()), client);
-}
-
-WebDevToolsFrontend* WebDevToolsFrontend::create(
-    WebLocalFrame* frame,
-    WebDevToolsFrontendClient* client,
-    const WebString& applicationLocale)
-{
-    return new WebDevToolsFrontendImpl(toWebLocalFrameImpl(frame), client);
-}
-
-WebDevToolsFrontendImpl::WebDevToolsFrontendImpl(
-    WebLocalFrameImpl* webFrame,
-    WebDevToolsFrontendClient* client)
+WebDevToolsFrontendImpl::WebDevToolsFrontendImpl(WebLocalFrameImpl* webFrame, WebDevToolsFrontendClient* client)
     : m_webFrame(webFrame)
     , m_client(client)
 {
@@ -70,9 +52,16 @@ WebDevToolsFrontendImpl::WebDevToolsFrontendImpl(
 
 WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl()
 {
+    // Q: where is this cleared?

[sof, 2015/03/15 14:10:56]

An explicit dispose() was removed in https://codereview.chromium.org/900543003/
, which did clear this ref. That review (or its commit message) doesn't offer an
indication as to why we should assume that this object will never be
finalized/destructed...as I cannot see where else it would be cleared, but
perhaps i'm overlooking something.

     ASSERT(!m_devtoolsHost);
 }
 
+DEFINE_TRACE(WebDevToolsFrontendImpl)
+{
+    visitor->trace(m_webFrame);
+    visitor->trace(m_devtoolsHost);
+}
+
 void WebDevToolsFrontendImpl::didClearWindowObject(WebLocalFrameImpl* frame)
 {
     if (m_webFrame == frame) {