Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1008153003: Revert of Send autocapitalize flags to the Android virtual keyboard based on Blink hints. (Closed)

Created:
5 years, 9 months ago by scheib
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Send autocapitalize flags to the Android virtual keyboard based on Blink hints. (patchset #6 id:100001 of https://codereview.chromium.org/1003143002/) Reason for revert: compile fail on http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/13039 ../content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:128:error: cannot find symbol if ((inputFlags & WebTextInputFlags.AutocapitalizeCharacters) != 0) { Original issue's description: > Send autocapitalize flags to the Android virtual keyboard based on Blink hints. > > This changes the behaviour of AdapterInputConnection to pass a > InputType.TYPE_TEXT_FLAG_CAP_* based on the > WebTextInputFlags.Autocapitalize* instead of doing it purely based on the > element's type. > > This CL requires the following Blink CL: > https://codereview.chromium.org/995363002 > > BUG=466930 > > Committed: https://crrev.com/d1421a5faf9dc2d3b3cad10640576b24a092d9ba > Cr-Commit-Position: refs/heads/master@{#322414} TBR=aurimas@chromium.org,shuchen@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466930 Committed: https://crrev.com/8477fbb1cb0668d5ebedbe359f9eec153d9634fa Cr-Commit-Position: refs/heads/master@{#322419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 2 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheib
Created Revert of Send autocapitalize flags to the Android virtual keyboard based on Blink hints.
5 years, 9 months ago (2015-03-26 17:57:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008153003/1
5 years, 9 months ago (2015-03-26 17:58:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 17:59:39 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 18:00:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8477fbb1cb0668d5ebedbe359f9eec153d9634fa
Cr-Commit-Position: refs/heads/master@{#322419}

Powered by Google App Engine
This is Rietveld 408576698