Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 995363002: Implement autocapitalize in Blink to be used by the embedder. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 9 months ago
Reviewers:
tkent
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, philipj_slow, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement autocapitalize in Blink to be used by the embedder. This CL implements autocapitalize in Blink, handling the logic and exposing the embedder the value it is expected to use. It is following this proposal: https://github.com/mounirlamouri/html-autocapitalize/blob/master/proposal.md The Intent to Ship can be found here: https://groups.google.com/a/chromium.org/d/msg/blink-dev/zF8dao594fs/2f1wyZOFseQJ BUG=466930 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192166

Patch Set 1 #

Patch Set 2 : ready for review #

Total comments: 5

Patch Set 3 : review comments applied #

Patch Set 4 : add more tests #

Patch Set 5 : update webexposed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -9 lines) Patch
A LayoutTests/fast/forms/autocapitalize.html View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 4 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/html/forms/BaseTextInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/BaseTextInputType.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/forms/InputType.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/html/forms/SearchInputType.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/forms/TextInputType.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/TextInputType.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 1 chunk +8 lines, -6 lines 0 comments Download
M Source/web/tests/data/text_input_flags.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebTextInputType.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
mlamouri (slow - plz ping)
5 years, 9 months ago (2015-03-17 21:15:26 UTC) #2
tkent
https://codereview.chromium.org/995363002/diff/20001/LayoutTests/fast/forms/autocapitalize.html File LayoutTests/fast/forms/autocapitalize.html (right): https://codereview.chromium.org/995363002/diff/20001/LayoutTests/fast/forms/autocapitalize.html#newcode1 LayoutTests/fast/forms/autocapitalize.html:1: <!DOCTYPE html> You should swap the content of screenorientation-api.html ...
5 years, 9 months ago (2015-03-17 22:53:51 UTC) #3
mlamouri (slow - plz ping)
Thank you for the review and sorry for the couple of stupid mistakes, I tried ...
5 years, 9 months ago (2015-03-18 10:08:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995363002/60001
5 years, 9 months ago (2015-03-18 10:16:10 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-18 10:16:13 UTC) #8
mlamouri (slow - plz ping)
On 2015/03/18 at 10:16:13, commit-bot wrote: > No LGTM from a valid reviewer yet. Only ...
5 years, 9 months ago (2015-03-18 10:22:47 UTC) #9
tkent
lgtm On 2015/03/18 10:08:16, Mounir Lamouri wrote: > I have updated the patch to no ...
5 years, 9 months ago (2015-03-18 23:24:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995363002/80001
5 years, 9 months ago (2015-03-19 11:46:52 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:41:24 UTC) #14
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192166

Powered by Google App Engine
This is Rietveld 408576698