Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1008113002: Remove LifecycleNotifier<>::m_context. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove LifecycleNotifier<>::m_context. It serves no purpose any longer to keep this self reference around, hence retire m_context. Also, move isContextThread() up to ExecutionContext; a more natural place to position the predicate. R=haraken BUG=462949 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -68 lines) Patch
M Source/core/dom/ContextLifecycleNotifier.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/ContextLifecycleObserver.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentLifecycleNotifier.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentLifecycleNotifier.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentLifecycleObserver.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/page/PageLifecycleNotifier.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/PageLifecycleNotifier.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/LifecycleContextTest.cpp View 2 chunks +2 lines, -16 lines 0 comments Download
M Source/platform/LifecycleNotifier.h View 7 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-14 08:18:54 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-14 08:34:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008113002/1
5 years, 9 months ago (2015-03-14 14:14:50 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 17:16:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191883

Powered by Google App Engine
This is Rietveld 408576698