Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: Source/platform/LifecycleContextTest.cpp

Issue 1008113002: Remove LifecycleNotifier<>::m_context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/PageLifecycleNotifier.cpp ('k') | Source/platform/LifecycleNotifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/LifecycleContextTest.cpp
diff --git a/Source/platform/LifecycleContextTest.cpp b/Source/platform/LifecycleContextTest.cpp
index 7998adfe22cd8bffef9967c90c532ebd363cc255..bf33b9028e3f2a2ffcdf528d5ac39eba6c558fb6 100644
--- a/Source/platform/LifecycleContextTest.cpp
+++ b/Source/platform/LifecycleContextTest.cpp
@@ -27,7 +27,9 @@
#include "config.h"
#include "platform/LifecycleNotifier.h"
+#include "platform/LifecycleObserver.h"
#include "platform/heap/Handle.h"
+
#include <gtest/gtest.h>
using namespace blink;
@@ -43,26 +45,10 @@ public:
return adoptPtrWillBeNoop(new DummyContext());
}
- void addObserver(TestingObserver* observer)
- {
- LifecycleNotifier<DummyContext, TestingObserver>::addObserver(observer);
- }
-
- void removeObserver(TestingObserver* observer)
- {
- LifecycleNotifier<DummyContext, TestingObserver>::removeObserver(observer);
- }
-
DEFINE_INLINE_TRACE()
{
LifecycleNotifier<DummyContext, TestingObserver>::trace(visitor);
}
-
-private:
- DummyContext()
- : LifecycleNotifier<DummyContext, TestingObserver>(this)
- {
- }
};
class TestingObserver final : public NoBaseWillBeGarbageCollectedFinalized<TestingObserver>, public LifecycleObserver<DummyContext, TestingObserver, DummyContext> {
« no previous file with comments | « Source/core/page/PageLifecycleNotifier.cpp ('k') | Source/platform/LifecycleNotifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698