sync/syncable/deferred_on_disk_directory_backing_store.cc - Issue 1008103002: Sync: Avoid 3 passes over SyncDarta DB when loading the directory from the disk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/deferred_on_disk_directory_backing_store.cc

Issue 1008103002: Sync: Avoid 3 passes over SyncDarta DB when loading the directory from the disk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/syncable/deferred_on_disk_directory_backing_store.h ('k') | sync/syncable/deferred_on_disk_directory_backing_store_unittest.cc » ('j') | sync/syncable/directory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/syncable/deferred_on_disk_directory_backing_store.cc

diff --git a/sync/syncable/deferred_on_disk_directory_backing_store.cc b/sync/syncable/deferred_on_disk_directory_backing_store.cc

index 0367e5bc6cccf3252ac91afb0d9ae12c2639675c..fbb7845ec38be540b909fea025e43bbd06a00b80 100644

--- a/sync/syncable/deferred_on_disk_directory_backing_store.cc

+++ b/sync/syncable/deferred_on_disk_directory_backing_store.cc

@@ -52,6 +52,7 @@ bool DeferredOnDiskDirectoryBackingStore::SaveChanges(

DirOpenResult DeferredOnDiskDirectoryBackingStore::Load(

Directory::MetahandlesMap* handles_map,

JournalIndex* delete_journals,

+ MetahandleSet* metahandles_to_purge,

Directory::KernelLoadInfo* kernel_load_info) {

// Open an in-memory database at first to create initial sync data needed by

// Directory.

@@ -61,7 +62,7 @@ DirOpenResult DeferredOnDiskDirectoryBackingStore::Load(

if (!InitializeTables())

return FAILED_OPEN_DATABASE;

- if (!LoadEntries(handles_map))

+ if (!LoadEntries(handles_map, metahandles_to_purge))

return FAILED_DATABASE_CORRUPT;

if (!LoadInfo(kernel_load_info))

return FAILED_DATABASE_CORRUPT;