sync/syncable/directory.h - Issue 1008103002: Sync: Avoid 3 passes over SyncDarta DB when loading the directory from the disk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/directory.h

Issue 1008103002: Sync: Avoid 3 passes over SyncDarta DB when loading the directory from the disk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/syncable/directory.h

diff --git a/sync/syncable/directory.h b/sync/syncable/directory.h

index 98706b61cece207234d38f593d30ca6921a01394..d9e176ad92b1484d08547cc9d7f7732f89f159be 100644

--- a/sync/syncable/directory.h

+++ b/sync/syncable/directory.h

@@ -599,11 +599,11 @@ class SYNC_EXPORT Directory {

// processed |snapshot| failed, for example, due to no disk space.

void HandleSaveChangesFailure(const SaveChangesSnapshot& snapshot);

- // Used by CheckTreeInvariants

+ // Used by CheckTreeInvariants.

void GetAllMetaHandles(BaseTransaction* trans, MetahandleSet* result);

+ // Used by VacuumAfterSaveChanges.

Nicolas Zea 2015/03/16 19:33:36 nit: may as well put a newline above (and below th

bool SafeToPurgeFromMemory(WriteTransaction* trans,

const EntryKernel* const entry) const;

// A helper used by GetTotalNodeCount.

void GetChildSetForKernel(

BaseTransaction*,

« no previous file with comments | « sync/syncable/deferred_on_disk_directory_backing_store_unittest.cc ('k') | sync/syncable/directory.cc » ('j') | no next file with comments »