Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1008053002: Disable Enhanced Bookmark for ICS devices (Closed)

Created:
5 years, 9 months ago by Ian Wen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Enhanced Bookmark for ICS devices M42 is the last version we ship to ICS devices. We want to make sure that ICS users only use the most stable bookmark manager. Therefore we should disable it on ICS now. BUG=466869 Committed: https://crrev.com/0a82fd525d1f4d64ce5f4e1c6a66c1fffd65a3dd Cr-Commit-Position: refs/heads/master@{#320823}

Patch Set 1 #

Patch Set 2 : Put build_info.h into android specific block to let it compile on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/bookmarks/enhanced_bookmarks_features.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Ian Wen
5 years, 9 months ago (2015-03-13 22:59:10 UTC) #2
Kibeom Kim (inactive)
lgtm
5 years, 9 months ago (2015-03-13 23:48:11 UTC) #4
Kibeom Kim (inactive)
5 years, 9 months ago (2015-03-13 23:48:58 UTC) #6
Ian Wen
sky@, could you ptal? We will permanently disable enhancedbookmark for ICS because that platform will ...
5 years, 9 months ago (2015-03-14 00:11:12 UTC) #8
sky
LGTM
5 years, 9 months ago (2015-03-16 16:27:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008053002/1
5 years, 9 months ago (2015-03-16 18:20:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/52743)
5 years, 9 months ago (2015-03-16 19:19:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008053002/20001
5 years, 9 months ago (2015-03-16 20:58:40 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 23:43:43 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 23:44:17 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a82fd525d1f4d64ce5f4e1c6a66c1fffd65a3dd
Cr-Commit-Position: refs/heads/master@{#320823}

Powered by Google App Engine
This is Rietveld 408576698