Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2754)

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.cc

Issue 1008053002: Disable Enhanced Bookmark for ICS devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put build_info.h into android specific block to let it compile on mac Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/enhanced_bookmarks_features.cc
diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
index 1992640e967b934469bd68af88ca166631565d03..142e5cb7092d05ce49d56fa9b3cc641ce4b846eb 100644
--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
@@ -22,6 +22,10 @@
#include "extensions/common/features/feature.h"
#include "extensions/common/features/feature_provider.h"
+#if defined(OS_ANDROID)
+#include "base/android/build_info.h"
+#endif
+
namespace {
const char kFieldTrialName[] = "EnhancedBookmarks";
@@ -135,6 +139,11 @@ void UpdateBookmarksExperimentState(
}
#if defined(OS_ANDROID)
+ if (base::android::BuildInfo::GetInstance()->sdk_int() <=
+ base::android::SdkVersion::SDK_VERSION_ICE_CREAM_SANDWICH_MR1) {
+ opt_out = true;
+ bookmarks_experiment_new_state = BOOKMARKS_EXPERIMENT_NONE;
+ }
bool opt_in = !opt_out &&
base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
switches::kEnhancedBookmarksExperiment) == "1";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698