Adding Test Fixture for initial test cases for the App Remoting Test Driver. Also includes the pub…

remoting/test/remote_host_info_fetcher.cc

Index: remoting/test/remote_host_info_fetcher.cc
diff --git a/remoting/test/remote_host_info_fetcher.cc b/remoting/test/remote_host_info_fetcher.cc
index e7dc0958da360cdffa482b6213c1a47aa404e7a3..f2b0e8fd390b48c5f4930a39cb9d8c63b895d636 100644
--- a/remoting/test/remote_host_info_fetcher.cc
+++ b/remoting/test/remote_host_info_fetcher.cc
@@ -25,9 +25,11 @@ const char kRequestTestOrigin[] =
 namespace remoting {
 namespace test {
 
-RemoteHostInfoFetcher::RemoteHostInfoFetcher() {}
+RemoteHostInfoFetcher::RemoteHostInfoFetcher() {
+}
 
-RemoteHostInfoFetcher::~RemoteHostInfoFetcher() {}
+RemoteHostInfoFetcher::~RemoteHostInfoFetcher() {
+}
 
 bool RemoteHostInfoFetcher::RetrieveRemoteHostInfo(
     const std::string& application_id,
@@ -62,14 +64,13 @@ bool RemoteHostInfoFetcher::RetrieveRemoteHostInfo(
 
   remote_host_info_callback_ = callback;
 
-  scoped_refptr<remoting::URLRequestContextGetter> request_context_getter;
-  request_context_getter = new remoting::URLRequestContextGetter(
+  request_context_getter_ = new remoting::URLRequestContextGetter(
       base::ThreadTaskRunnerHandle::Get(),   // network_runner
       base::ThreadTaskRunnerHandle::Get());  // file_runner
 
   request_.reset(
       net::URLFetcher::Create(GURL(service_url), net::URLFetcher::POST, this));
-  request_->SetRequestContext(request_context_getter.get());
+  request_->SetRequestContext(request_context_getter_.get());

[Wez, 2015/03/16 22:19:10]

SetRequestContext takes a reference to the getter (the API should really be
updated to take a const scoped_refptr<>&...) , so you can just pass it in
without keeping a reference to it yourself.

[joedow, 2015/03/18 20:13:09]

Discussed offline, a reference needs to be held until the request completes :(

   request_->AddExtraRequestHeader("Authorization: OAuth " + access_token);
   request_->AddExtraRequestHeader(kRequestTestOrigin);
   request_->SetUploadData("application/json; charset=UTF-8", "{}");