Adding Test Fixture for initial test cases for the App Remoting Test Driver. Also includes the pub…

remoting/test/remote_host_info_fetcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/test/remote_host_info_fetcher.h"
 
 #include "base/bind.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/values.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_fetcher.h"
 #include "remoting/base/url_request_context_getter.h"
 
 namespace {
 const char kRequestTestOrigin[] =
     "Origin: chrome-extension://ljacajndfccfgnfohlgkdphmbnpkjflk";
 }
 
 namespace remoting {
 namespace test {
 
-RemoteHostInfoFetcher::RemoteHostInfoFetcher() {}
+RemoteHostInfoFetcher::RemoteHostInfoFetcher() {
+}
 
-RemoteHostInfoFetcher::~RemoteHostInfoFetcher() {}
+RemoteHostInfoFetcher::~RemoteHostInfoFetcher() {
+}
 
 bool RemoteHostInfoFetcher::RetrieveRemoteHostInfo(
     const std::string& application_id,
     const std::string& access_token,
     ServiceEnvironment service_environment,
     const RemoteHostInfoCallback& callback) {
   DCHECK(!application_id.empty());
   DCHECK(!access_token.empty());
   DCHECK(!callback.is_null());
   DCHECK(remote_host_info_callback_.is_null());
@@ skipping 14 matching lines @@
                                        application_id.c_str());
       break;
 
     default:
       LOG(ERROR) << "Unrecognized service type: " << service_environment;
       return false;
   }
 
   remote_host_info_callback_ = callback;
 
-  scoped_refptr<remoting::URLRequestContextGetter> request_context_getter;
-  request_context_getter = new remoting::URLRequestContextGetter(
+  request_context_getter_ = new remoting::URLRequestContextGetter(
       base::ThreadTaskRunnerHandle::Get(),   // network_runner
       base::ThreadTaskRunnerHandle::Get());  // file_runner
 
   request_.reset(
       net::URLFetcher::Create(GURL(service_url), net::URLFetcher::POST, this));
-  request_->SetRequestContext(request_context_getter.get());
+  request_->SetRequestContext(request_context_getter_.get());

[Wez, 2015/03/16 22:19:10]

SetRequestContext takes a reference to the getter (the API should really be
updated to take a const scoped_refptr<>&...) , so you can just pass it in
without keeping a reference to it yourself.

[joedow, 2015/03/18 20:13:09]

Discussed offline, a reference needs to be held until the request completes :(

   request_->AddExtraRequestHeader("Authorization: OAuth " + access_token);
   request_->AddExtraRequestHeader(kRequestTestOrigin);
   request_->SetUploadData("application/json; charset=UTF-8", "{}");
   request_->Start();
 
   return true;
 }
 
 void RemoteHostInfoFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
   DCHECK(source);
@@ skipping 48 matching lines @@
                         &remote_host_info.authorization_code);
     response->GetString("sharedSecret", &remote_host_info.shared_secret);
   }
 
   remote_host_info_callback_.Run(remote_host_info);
   remote_host_info_callback_.Reset();
 }
 
 }  // namespace test
 }  // namespace remoting