Chromium Code Reviews| Index: remoting/test/app_remoting_test_driver_environment.h |
| diff --git a/remoting/test/app_remoting_test_driver_environment.h b/remoting/test/app_remoting_test_driver_environment.h |
| index c814f0b2995d3512232213cabe52dc4539905fa1..0377ba1c41aa875f319e507e4dd9f93c7c67af84 100644 |
| --- a/remoting/test/app_remoting_test_driver_environment.h |
| +++ b/remoting/test/app_remoting_test_driver_environment.h |
| @@ -23,9 +23,8 @@ struct RemoteHostInfo; |
| // access tokens and retrieving remote host connection information. |
| class AppRemotingTestDriverEnvironment : public testing::Environment { |
| public: |
| - AppRemotingTestDriverEnvironment( |
| - const std::string& user_name, |
| - ServiceEnvironment service_environment); |
| + AppRemotingTestDriverEnvironment(const std::string& user_name, |
| + ServiceEnvironment service_environment); |
| ~AppRemotingTestDriverEnvironment() override; |
| // Returns false if a valid access token cannot be retrieved. |
| @@ -37,9 +36,12 @@ class AppRemotingTestDriverEnvironment : public testing::Environment { |
| // Synchronously request remote host information for |application_id|. |
| // Returns true if the request was successful and |remote_host_info| is valid. |
| - bool GetRemoteHostInfoForApplicationId( |
| - const std::string& application_id, |
| - RemoteHostInfo* remote_host_info); |
| + bool GetRemoteHostInfoForApplicationId(const std::string& application_id, |
| + RemoteHostInfo* remote_host_info); |
| + |
| + // Retrieves connection information for all known applications and displays |
| + // their availability. |
|
Wez
2015/03/16 22:19:10
Displays it where?
joedow
2015/03/18 20:13:09
Done.
|
| + void ShowHostAvailability(); |
| // Used to set fake/mock objects for AppRemotingTestDriverEnvironment tests. |
| void SetAccessTokenFetcherForTest(AccessTokenFetcher* access_token_fetcher); |
| @@ -59,13 +61,11 @@ class AppRemotingTestDriverEnvironment : public testing::Environment { |
| // Called after the access token fetcher completes. |
| // The tokens will be empty on failure. |
| - void OnAccessTokenRetrieved( |
| - base::Closure done_closure, |
| - const std::string& access_token, |
| - const std::string& refresh_token); |
| + void OnAccessTokenRetrieved(base::Closure done_closure, |
| + const std::string& access_token, |
| + const std::string& refresh_token); |
| // Called after the remote host info fetcher completes. |
| - // |remote_host_info| is not modified on failure. |
|
Wez
2015/03/16 22:19:10
RemoteHostInfo _is_ now modified on failure, then?
joedow
2015/03/18 20:13:09
It is, I was treating 'pending' as a failure howev
|
| void OnRemoteHostInfoRetrieved( |
| base::Closure done_closure, |
| RemoteHostInfo* remote_host_info, |