Adding Test Fixture for initial test cases for the App Remoting Test Driver. Also includes the pub…

remoting/test/app_remoting_test_driver_environment.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_TEST_APP_REMOTING_TEST_DRIVER_ENVIRONMENT_H_
 #define REMOTING_TEST_APP_REMOTING_TEST_DRIVER_ENVIRONMENT_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "remoting/test/remote_host_info_fetcher.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace remoting {
 namespace test {
 
 class AccessTokenFetcher;
 class RefreshTokenStore;
 struct RemoteHostInfo;
 
 // Globally accessible to all test fixtures and cases and has its
 // lifetime managed by the GTest framework.  It is responsible for managing
 // access tokens and retrieving remote host connection information.
 class AppRemotingTestDriverEnvironment : public testing::Environment {
  public:
-  AppRemotingTestDriverEnvironment(
-      const std::string& user_name,
-      ServiceEnvironment service_environment);
+  AppRemotingTestDriverEnvironment(const std::string& user_name,
+                                   ServiceEnvironment service_environment);
   ~AppRemotingTestDriverEnvironment() override;
 
   // Returns false if a valid access token cannot be retrieved.
   bool Initialize(const std::string& auth_code);
 
   // Synchronously request a new access token using |refresh_token_|.
   // Returns true if a valid access token has been retrieved.
   bool RefreshAccessToken();
 
   // Synchronously request remote host information for |application_id|.
   // Returns true if the request was successful and |remote_host_info| is valid.
-  bool GetRemoteHostInfoForApplicationId(
-      const std::string& application_id,
-      RemoteHostInfo* remote_host_info);
+  bool GetRemoteHostInfoForApplicationId(const std::string& application_id,
+                                         RemoteHostInfo* remote_host_info);
+
+  // Retrieves connection information for all known applications and displays
+  // their availability.

[Wez, 2015/03/16 22:19:10]

Displays it where?

[joedow, 2015/03/18 20:13:09]

Done.

+  void ShowHostAvailability();
 
   // Used to set fake/mock objects for AppRemotingTestDriverEnvironment tests.
   void SetAccessTokenFetcherForTest(AccessTokenFetcher* access_token_fetcher);
   void SetRefreshTokenStoreForTest(RefreshTokenStore* refresh_token_store);
   void SetRemoteHostInfoFetcherForTest(
       RemoteHostInfoFetcher* remote_host_info_fetcher);
 
   // Accessors for fields used by tests.
   const std::string& access_token() const { return access_token_; }
   const std::string& user_name() const { return user_name_; }
 
  private:
   // Used to retrieve an access token.  If |auth_code| is empty, then the stored
   // refresh_token will be used instead of |auth_code|.
   // Returns true if a new, valid access token has been retrieved.
   bool RetrieveAccessToken(const std::string& auth_code);
 
   // Called after the access token fetcher completes.
   // The tokens will be empty on failure.
-  void OnAccessTokenRetrieved(
-      base::Closure done_closure,
-      const std::string& access_token,
-      const std::string& refresh_token);
+  void OnAccessTokenRetrieved(base::Closure done_closure,
+                              const std::string& access_token,
+                              const std::string& refresh_token);
 
   // Called after the remote host info fetcher completes.
-  // |remote_host_info| is not modified on failure.

[Wez, 2015/03/16 22:19:10]

RemoteHostInfo _is_ now modified on failure, then?

[joedow, 2015/03/18 20:13:09]

It is, I was treating 'pending' as a failure however I think it is important to
return those details to the caller who is going to call 'IsReadyForConnection'
anyway which will still return false.

   void OnRemoteHostInfoRetrieved(
       base::Closure done_closure,
       RemoteHostInfo* remote_host_info,
       const RemoteHostInfo& retrieved_remote_host_info);
 
   // Used for authenticating with the app remoting service API.
   std::string access_token_;
 
   // Used to retrieve an access token.
   std::string refresh_token_;
@@ skipping 18 matching lines @@
 
 // Unfortunately a global var is how the GTEST framework handles sharing data
 // between tests and keeping long-lived objects around.  Used to share auth
 // tokens and remote host connection information across tests.
 extern AppRemotingTestDriverEnvironment* AppRemotingSharedData;
 
 }  // namespace test
 }  // namespace remoting
 
 #endif  // REMOTING_TEST_APP_REMOTING_TEST_DRIVER_ENVIRONMENT_H_