Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1007953003: Revert of Increase YUV video clamping (Closed)

Created:
5 years, 9 months ago by pdr.
Modified:
5 years, 9 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Increase YUV video clamping (patchset #4 id:60001 of https://codereview.chromium.org/1008493002/) Reason for revert: I think this patch caused blink layouttest failures (e.g., media/video-colorspace-yuv420.html). See http://crbug.com/467283 Original issue's description: > Increase YUV video clamping > > The current clamping is not enough to avoid bleeding issues. This is > exposed when changing the background color in CreateEdgeBleedPass from > black to gray. The reason it works now is because interpolating U/V > textures from black (YUV = 0, 0, 0) to green (YUV = 149, 43, 21) will > still result in saturated green pixels (RGB = 0, 255, 0). All YUV values > in the range (149, 0-43, 0-21) will end up as RGB = (0, 255, 0). > > The current clamping is not enough, because the calculation > '0.5f / quad->tex_size.width()' is using the Y texture size, the highest > resolution plane, but the U/V texture size is only half of that. This CL > changes tex_size to represent the lowest resolution texture instead. > > BUG=429640 > > Committed: https://crrev.com/4be817dd606efdba1614d32608ddd6e16bfa687d > Cr-Commit-Position: refs/heads/master@{#320567} TBR=enne@chromium.org,danakj@chromium.org,wfh@chromium.org,magjed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429640, 467283 Committed: https://crrev.com/9764be34e6e97a05a0bff5a4448a5ac56e735b85 Cr-Commit-Position: refs/heads/master@{#320642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -39 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M cc/quads/draw_quad_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M cc/quads/yuv_video_draw_quad.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/quads/yuv_video_draw_quad.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/test/data/yuv_stripes.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_alpha.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_offset.png View Binary file 0 comments Download
M content/common/cc_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/cc_messages_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
pdr.
Created Revert of Increase YUV video clamping
5 years, 9 months ago (2015-03-14 04:24:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007953003/1
5 years, 9 months ago (2015-03-14 04:25:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-14 04:25:53 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 04:26:31 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9764be34e6e97a05a0bff5a4448a5ac56e735b85
Cr-Commit-Position: refs/heads/master@{#320642}

Powered by Google App Engine
This is Rietveld 408576698