Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6566)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_page_header.html

Issue 1007803003: Polymer Settings Scaffold in MD-Settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Scaffold2
Patch Set: Remove pages to shrink CL Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_page_header.html
diff --git a/chrome/browser/resources/settings/settings_page/settings_page_header.html b/chrome/browser/resources/settings/settings_page/settings_page_header.html
new file mode 100644
index 0000000000000000000000000000000000000000..978c01c11de85d4dc21312a2dd04f0763800217c
--- /dev/null
+++ b/chrome/browser/resources/settings/settings_page/settings_page_header.html
@@ -0,0 +1,12 @@
+<link rel="import" href="chrome://resources/polymer/core-icon/core-icon.html">
+
+<polymer-element name="cr-settings-page-header" layout horizontal center>
+ <template>
+ <link rel="stylesheet" href="settings_page_header.css">
+ <div id="icon-container">
Jeremy Klein 2015/03/13 23:51:51 nit: this should be a class.
michaelpg 2015/03/17 06:30:15 I'm not sure what you mean. Do you mean we should
Jeremy Klein 2015/03/17 06:38:00 No, sorry I mean the id should be a class instead
michaelpg 2015/03/17 21:52:05 Oh, haha. Yeah, it doesn't have to be an ID and it
+ <core-icon icon="{{page.icon}}"></core-icon>
+ </div>
+ <h1>{{page.pageTitle}}</h1>
+ </template>
+ <script src="settings_page_header.js"></script>
+</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698