chrome/browser/resources/settings/settings_page/settings_page_header.html - Issue 1007803003: Polymer Settings Scaffold in MD-Settings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_page_header.html

Issue 1007803003: Polymer Settings Scaffold in MD-Settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Scaffold2

Patch Set: Remove pages to shrink CL Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_page/settings_page_header.css ('K') | « chrome/browser/resources/settings/settings_page/settings_page_header.css ('k') | chrome/browser/resources/settings/settings_page/settings_page_header.js » ('j') | chrome/browser/resources/settings/settings_resources.grd » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/core-icon/core-icon.html">

	2

	3 <polymer-element name="cr-settings-page-header" layout horizontal center>

	4 <template>

	5 <link rel="stylesheet" href="settings_page_header.css">

	6 <div id="icon-container">
	Jeremy Klein 2015/03/13 23:51:51 nit: this should be a class. nit: this should be a class. michaelpg 2015/03/17 06:30:15 I'm not sure what you mean. Do you mean we should Show quoted text On 2015/03/13 23:51:51, Jeremy Klein wrote: > nit: this should be a class. I'm not sure what you mean. Do you mean we should wrap core-icon in cr-icon? I don't know if that's necessary as it's a pretty basic building block. Jeremy Klein 2015/03/17 06:38:00 No, sorry I mean the id should be a class instead Show quoted text On 2015/03/17 06:30:15, michaelpg wrote: > On 2015/03/13 23:51:51, Jeremy Klein wrote: > > nit: this should be a class. > > I'm not sure what you mean. Do you mean we should wrap core-icon in cr-icon? I > don't know if that's necessary as it's a pretty basic building block. No, sorry I mean the id should be a class instead here. If it needs to be an id for convenient js access (looks like it isn't used that way at the moment), it should be camel-case instead of dashes. michaelpg 2015/03/17 21:52:05 Oh, haha. Yeah, it doesn't have to be an ID and it Show quoted text On 2015/03/17 06:38:00, Jeremy Klein wrote: > On 2015/03/17 06:30:15, michaelpg wrote: > > On 2015/03/13 23:51:51, Jeremy Klein wrote: > > > nit: this should be a class. > > > > I'm not sure what you mean. Do you mean we should wrap core-icon in cr-icon? I > > don't know if that's necessary as it's a pretty basic building block. > > No, sorry I mean the id should be a class instead here. If it needs to be an id > for convenient js access (looks like it isn't used that way at the moment), it > should be camel-case instead of dashes. Oh, haha. Yeah, it doesn't have to be an ID and it makes more sense as a class.
	7 <core-icon icon="{{page.icon}}"></core-icon>

	8 </div>

	9 <h1>{{page.pageTitle}}</h1>

	10 </template>

	11 <script src="settings_page_header.js"></script>

	12 </polymer-element>

OLD	NEW