Change defaults in server mode

Change defaults in server mode

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/cd9fe8550577b247654a33e2d9e3213807e80e52

[Siggi Cherem (dart-lang), 2015-03-19 21:41:42]

sigmund@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2015-03-19 22:32:22]

lgtm

https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart
File lib/src/options.dart (right):

https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart#ne...
lib/src/options.dart:336: abbr: 'i', help: 'Dump summary information',
defaultsTo: false)
do we need to fix this option to?

[Siggi Cherem (dart-lang), 2015-03-19 22:44:51]

https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart
File lib/src/options.dart (right):

https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart#ne...
lib/src/options.dart:336: abbr: 'i', help: 'Dump summary information',
defaultsTo: false)
On 2015/03/19 22:32:22, John Messerly wrote:
> do we need to fix this option to?

Unfortunately we can't with 'flags'. Boolean flags still default to false
(rather than null) if I remove this.

[Jennifer Messerly, 2015-03-19 22:48:00]

https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart
File lib/src/options.dart (right):

https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart#ne...
lib/src/options.dart:336: abbr: 'i', help: 'Dump summary information',
defaultsTo: false)
On 2015/03/19 22:44:50, Siggi Cherem (dart-lang) wrote:
> On 2015/03/19 22:32:22, John Messerly wrote:
> > do we need to fix this option to?
> 
> Unfortunately we can't with 'flags'. Boolean flags still default to false
> (rather than null) if I remove this.

just have --server imply it?

[Siggi Cherem (dart-lang), 2015-03-19 22:48:20]

On 2015/03/19 22:44:51, Siggi Cherem (dart-lang) wrote:
> https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart
> File lib/src/options.dart (right):
> 
>
https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart#ne...
> lib/src/options.dart:336: abbr: 'i', help: 'Dump summary information',
> defaultsTo: false)
> On 2015/03/19 22:32:22, John Messerly wrote:
> > do we need to fix this option to?
> 
> Unfortunately we can't with 'flags'. Boolean flags still default to false
> (rather than null) if I remove this.

AH, I found a way around it. Write explicitly: `defaultsTo: null`

[Siggi Cherem (dart-lang), 2015-03-19 22:49:42]

Committed patchset #3 (id:40001) manually as
cd9fe8550577b247654a33e2d9e3213807e80e52 (presubmit successful).

[Siggi Cherem (dart-lang), 2015-03-19 22:50:12]

yay :)

https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart
File lib/src/options.dart (right):

https://codereview.chromium.org/1007703004/diff/20001/lib/src/options.dart#ne...
lib/src/options.dart:336: abbr: 'i', help: 'Dump summary information',
defaultsTo: false)
On 2015/03/19 22:47:59, John Messerly wrote:
> On 2015/03/19 22:44:50, Siggi Cherem (dart-lang) wrote:
> > On 2015/03/19 22:32:22, John Messerly wrote:
> > > do we need to fix this option to?
> > 
> > Unfortunately we can't with 'flags'. Boolean flags still default to false
> > (rather than null) if I remove this.
> 
> just have --server imply it?

Done.