Change defaults in server mode

lib/src/options.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Set of flags and options passed to the compiler
 library dev_compiler.src.options;
 
 import 'dart:io';
 
 import 'package:args/args.dart';
@@ skipping 200 matching lines @@
       this.onlyInferConstsAndFinalFields: ResolverOptions.onlyInferConstAndFinalFieldsDefault,
       this.nonnullableTypes: TypeOptions.NONNULLABLE_TYPES, this.help: false,
       this.useMockSdk: false, this.dartSdkPath, this.logLevel: Level.SEVERE,
       this.emitSourceMaps: true, this.entryPointFile: null,
       this.serverMode: false, this.port: 8080, this.runtimeDir});
 }
 
 /// Parses options from the command-line
 CompilerOptions parseOptions(List<String> argv) {
   ArgResults args = argParser.parse(argv);
-  var levelName = args['log'].toUpperCase();
+  var serverMode = args['server'];
+  var logLevel = serverMode ? Level.ALL : Level.SEVERE;
+  var levelName = args['log'];
+  if (levelName != null) {
+    levelName = levelName.toUpperCase();
+    logLevel = Level.LEVELS.firstWhere((l) => l.name == levelName,
+        orElse: () => logLevel);
+  }
   var useColors = stdioType(stdout) == StdioType.TERMINAL;
   var sdkPath = args['dart-sdk'];
   if (sdkPath == null && !args['mock-sdk']) {
     sdkPath = getSdkDir(argv).path;
   }
   var runtimeDir = args['runtime-dir'];
   if (runtimeDir == null) {
     runtimeDir = _computeRuntimeDir();
   }
+  var outputDir = args['out'];
+  if (outputDir == null && serverMode) {
+    outputDir = Directory.systemTemp.createTempSync("dev_compiler_out_").path;
+  }
   return new CompilerOptions(
       allowConstCasts: args['allow-const-casts'],
       checkSdk: args['sdk-check'],
-      dumpInfo: args['dump-info'],
+      dumpInfo: args['dump-info'] || serverMode,
       dumpInfoFile: args['dump-info-file'],
       dumpSrcDir: args['dump-src-to'],
-      forceCompile: args['force-compile'],
+      forceCompile: args['force-compile'] || serverMode,
       formatOutput: args['dart-gen-fmt'],
       ignoreTypes: args['ignore-types'],
       outputDart: args['dart-gen'],
-      outputDir: args['out'],
+      outputDir: outputDir,
       covariantGenerics: args['covariant-generics'],
       relaxedCasts: args['relaxed-casts'],
       useColors: useColors,
       useMultiPackage: args['use-multi-package'],
       packageRoot: args['package-root'],
       packagePaths: args['package-paths'].split(','),
       inferFromOverrides: args['infer-from-overrides'],
       inferTransitively: args['infer-transitively'],
       onlyInferConstsAndFinalFields: args['infer-only-finals'],
       nonnullableTypes: optionsToList(args['nonnullable'],
           defaultValue: TypeOptions.NONNULLABLE_TYPES),
       help: args['help'],
       useMockSdk: args['mock-sdk'],
       dartSdkPath: sdkPath,
-      logLevel: Level.LEVELS.firstWhere((Level l) => l.name == levelName,
-          orElse: () => Level.SEVERE),
+      logLevel: logLevel,
       emitSourceMaps: args['source-maps'],
       entryPointFile: args.rest.length == 0 ? null : args.rest.first,
-      serverMode: args['server'],
+      serverMode: serverMode,
       port: int.parse(args['port']),
       runtimeDir: runtimeDir);
 }
 
 final ArgParser argParser = new ArgParser()
   // resolver/checker options
   ..addFlag('allow-const-casts',
       help: 'Allow casts in const contexts', defaultsTo: true)
   ..addFlag('sdk-check',
       abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
@@ skipping 43 matching lines @@
       help: 'Where to find dev_compiler\'s runtime files', defaultsTo: null)
 
   // general options
   ..addFlag('help', abbr: 'h', help: 'Display this message')
   ..addFlag('server', help: 'Run as a development server.', defaultsTo: false)
   ..addOption('port',
       help: 'Port where to serve files from (used only when --serve is on)',
       defaultsTo: '8080')
   ..addFlag('force-compile',
       help: 'Compile code with static errors', defaultsTo: false)
-  ..addOption('log', abbr: 'l', help: 'Logging level', defaultsTo: 'severe')
+  ..addOption('log', abbr: 'l', help: 'Logging level (defaults to severe)')
   ..addFlag('dump-info',
       abbr: 'i', help: 'Dump summary information', defaultsTo: false)

[Jennifer Messerly, 2015/03/19 22:32:22]

do we need to fix this option to?

[Siggi Cherem (dart-lang), 2015/03/19 22:44:50]

Unfortunately we can't with 'flags'. Boolean flags still default to false
(rather than null) if I remove this.

[Jennifer Messerly, 2015/03/19 22:47:59]

just have --server imply it?

[Siggi Cherem (dart-lang), 2015/03/19 22:50:12]

Done.

   ..addOption('dump-info-file',
       abbr: 'f',
       help: 'Dump info json file (requires dump-info)',
       defaultsTo: null);
 
 /// Tries to find the `lib/runtime/` directory of the dev_compiler package. This
 /// works when running devc from it's sources or from a snapshot that is
 /// activated via `pub global activate`.
 String _computeRuntimeDir() {
   var scriptUri = Platform.script;
@@ skipping 35 matching lines @@
     // The pub-cache directory is two levels up, but we verify that the layout
     // looks correct.
     if (path.basename(dir) != 'dev_compiler') return null;
     dir = path.dirname(dir);
     if (path.basename(dir) != 'global_packages') return null;
     dir = path.dirname(dir);
     return path.join(dir, cacheDir, 'lib', 'runtime');
   }
   return null;
 }