[bindings] Utilize ScriptValue::from and remove IDB* => ScriptValue conversion methods

[bindings] Utilize ScriptValue::from and remove IDB* => ScriptValue conversion methods

R=haraken@chromium.org, jsbell@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191843

[vivekg, 2015-03-13 09:16:48]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-03-13 09:16:48]

PTAL, thanks.

[vivekg, 2015-03-13 11:07:08]

haraken@, good to go?

[haraken, 2015-03-13 12:48:10]

LGTM

https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
File Source/bindings/modules/v8/V8BindingForModules.cpp (left):

https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
Source/bindings/modules/v8/V8BindingForModules.cpp:404: v8::HandleScope
handleScope(isolate);

The previous code was creating a HandleScope before converting the value, but
the new code isn't. I hope this is fine (because we'll have a HandleScope
somewhere above in the stack) but please check that all tests pass before
landing the CL.

https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
File Source/bindings/modules/v8/V8BindingForModules.cpp (right):

https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
Source/bindings/modules/v8/V8BindingForModules.cpp:402: IDBKey*
scriptValueToIDBKey(v8::Isolate* isolate, const ScriptValue& scriptValue)

Can we now remove this?

https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
Source/bindings/modules/v8/V8BindingForModules.cpp:410: IDBKeyRange*
scriptValueToIDBKeyRange(v8::Isolate* isolate, const ScriptValue& scriptValue)

Can we now remove this?

[vivekg, 2015-03-13 12:51:28]

On 2015/03/13 at 12:48:10, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
> File Source/bindings/modules/v8/V8BindingForModules.cpp (left):
> 
>
https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
> Source/bindings/modules/v8/V8BindingForModules.cpp:404: v8::HandleScope
handleScope(isolate);
> 
> The previous code was creating a HandleScope before converting the value, but
the new code isn't. I hope this is fine (because we'll have a HandleScope
somewhere above in the stack) but please check that all tests pass before
landing the CL.

Yes you are right. In this case its already handled by being on the stack. Also
all the test are passed as per the bots.

> 
>
https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
> File Source/bindings/modules/v8/V8BindingForModules.cpp (right):
> 
>
https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
> Source/bindings/modules/v8/V8BindingForModules.cpp:402: IDBKey*
scriptValueToIDBKey(v8::Isolate* isolate, const ScriptValue& scriptValue)
> 
> Can we now remove this?
> 
>
https://codereview.chromium.org/1007703003/diff/20001/Source/bindings/modules...
> Source/bindings/modules/v8/V8BindingForModules.cpp:410: IDBKeyRange*
scriptValueToIDBKeyRange(v8::Isolate* isolate, const ScriptValue& scriptValue)
> 
> Can we now remove this?

Yes this would be followed up in the script_value_cast<> patch as suggested by
you.

[vivekg, 2015-03-13 13:39:12]

haraken@, shall we go ahead and land this if its ok with you?

[vivekg, 2015-03-13 14:32:41]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2015-03-13 14:33:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007703003/20001

[commit-bot: I haz the power, 2015-03-13 14:36:35]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191843