Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: Source/bindings/modules/v8/V8BindingForModules.h

Issue 1007703003: [bindings] Utilize ScriptValue::from and remove IDB* => ScriptValue conversion methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/modules/v8/V8BindingForModules.h
diff --git a/Source/bindings/modules/v8/V8BindingForModules.h b/Source/bindings/modules/v8/V8BindingForModules.h
index 3a5c9e89c180be0d1539809c0043895cf78d48af..4919633efa064d8287c418309145bfd87ba44a5a 100644
--- a/Source/bindings/modules/v8/V8BindingForModules.h
+++ b/Source/bindings/modules/v8/V8BindingForModules.h
@@ -24,9 +24,6 @@ bool injectV8KeyIntoV8Value(v8::Isolate*, v8::Local<v8::Value> key, v8::Local<v8
// For use by Source/modules/indexeddb:
IDBKey* createIDBKeyFromScriptValueAndKeyPath(v8::Isolate*, const ScriptValue&, const IDBKeyPath&);
bool canInjectIDBKeyIntoScriptValue(v8::Isolate*, const ScriptValue&, const IDBKeyPath&);
-ScriptValue idbAnyToScriptValue(ScriptState*, IDBAny*);
-ScriptValue idbKeyToScriptValue(ScriptState*, const IDBKey*);
-ScriptValue idbKeyPathToScriptValue(ScriptState*, const IDBKeyPath&);
IDBKey* scriptValueToIDBKey(v8::Isolate*, const ScriptValue&);
IDBKeyRange* scriptValueToIDBKeyRange(v8::Isolate*, const ScriptValue&);
ScriptValue deserializeScriptValue(ScriptState*, SerializedScriptValue*, const Vector<blink::WebBlobInfo>*);
@@ -37,17 +34,17 @@ void assertPrimaryKeyValidOrInjectable(ScriptState*, PassRefPtr<SharedBuffer>, c
template <>
struct NativeValueTraits<SQLValue> {
- static SQLValue nativeValue(const v8::Local<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
- {
- if (value.IsEmpty() || value->IsNull())
- return SQLValue();
- if (value->IsNumber())
- return SQLValue(value->NumberValue());
- V8StringResource<> stringValue(value);
- if (!stringValue.prepare(exceptionState))
- return SQLValue();
- return SQLValue(stringValue);
- }
+ static SQLValue nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);
+};
+
+template <>
+struct NativeValueTraits<IDBKey*> {
+ static IDBKey* nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);
+};
+
+template <>
+struct NativeValueTraits<IDBKeyRange*> {
+ static IDBKeyRange* nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698