Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Unified Diff: Source/core/layout/LayoutBox.h

Issue 1007623003: Fix incorrect percentage top for positioned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: New approach by adding a more simple api to get containingBlock's height Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutBox.h
diff --git a/Source/core/layout/LayoutBox.h b/Source/core/layout/LayoutBox.h
index 0310e4415eaf635a9e75dbe0101ecdaac40ebace..99a3260891a8034a3b4691ce40135e0791c6fbb8 100644
--- a/Source/core/layout/LayoutBox.h
+++ b/Source/core/layout/LayoutBox.h
@@ -476,6 +476,8 @@ public:
virtual void mapRectToPaintInvalidationBacking(const LayoutBoxModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const override;
virtual void invalidatePaintForOverhangingFloats(bool paintAllDescendants);
+ LayoutUnit containingBlockLogicalHeight() const;
mstensho (USE GERRIT) 2015/03/26 12:53:37 Need a more descriptive name, so that nobody gets
changseok 2015/03/30 07:17:57 I'm not good at naming anything too. :p How about
mstensho (USE GERRIT) 2015/04/13 21:40:04 Sounds good.
Timothy Loh 2015/04/14 09:57:48 This name is misleading. Maybe [...]ForGetComputed
+
virtual LayoutUnit containingBlockLogicalWidthForContent() const override;
LayoutUnit containingBlockLogicalHeightForContent(AvailableLogicalHeightType) const;

Powered by Google App Engine
This is Rietveld 408576698