Source/core/css/LayoutStyleCSSValueMapping.cpp - Issue 1007623003: Fix incorrect percentage top for positioned elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/LayoutStyleCSSValueMapping.cpp

Issue 1007623003: Fix incorrect percentage top for positioned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New approach by adding a more simple api to get containingBlock's height Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-expected.txt ('k') | Source/core/layout/LayoutBox.h » ('j') | Source/core/layout/LayoutBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/LayoutStyleCSSValueMapping.cpp

diff --git a/Source/core/css/LayoutStyleCSSValueMapping.cpp b/Source/core/css/LayoutStyleCSSValueMapping.cpp

index c47287c7fdc23ba411d88908a809859cb0015e4c..09abddc679738167e31bc08d8642498a0801b616 100644

--- a/Source/core/css/LayoutStyleCSSValueMapping.cpp

+++ b/Source/core/css/LayoutStyleCSSValueMapping.cpp

@@ -170,10 +170,10 @@ static PassRefPtrWillBeRawPtr<CSSValue> valueForPositionOffset(const LayoutStyle

return nullptr;

}

- if (offset.isPercent() && renderer && renderer->isBox()) {

+ if (offset.isPercent() && renderer && renderer->isBox() && renderer->isPositioned()) {

LayoutUnit containingBlockSize = (propertyID == CSSPropertyLeft || propertyID == CSSPropertyRight) ?

toLayoutBox(renderer)->containingBlockLogicalWidthForContent() :

- toLayoutBox(renderer)->containingBlockLogicalHeightForContent(ExcludeMarginBorderPadding);

+ toLayoutBox(renderer)->containingBlockLogicalHeight();

return zoomAdjustedPixelValue(valueForLength(offset, containingBlockSize), style);

}

if (offset.isAuto()) {